You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/08/08 19:35:21 UTC
Review Request 71258: Tracked weight info in the Role struct in the
allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71258/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Repository: mesos
Description
-------
Tracked weight info in the Role struct in the allocator.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp 29dfa9f828f452b1aed8162c1e13f96d20907553
src/master/allocator/mesos/hierarchical.cpp f1fa838d654816aba14ac032174bf1522b7ae033
Diff: https://reviews.apache.org/r/71258/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 71258: Tracked weight info in the Role struct in
the allocator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71258/#review217134
-----------------------------------------------------------
Bad review!
Reviews applied: [71258, 71257, 71255, 71254]
Error:
2019-08-08 21:45:05 URL:https://reviews.apache.org/r/71257/diff/raw/ [2246/2246] -> "71257.patch" [1]
error: patch failed: src/master/allocator/mesos/sorter/drf/sorter.cpp:15
error: src/master/allocator/mesos/sorter/drf/sorter.cpp: patch does not apply
error: patch failed: src/master/allocator/mesos/sorter/random/sorter.cpp:16
error: src/master/allocator/mesos/sorter/random/sorter.cpp: patch does not apply
- Mesos Reviewbot
On Aug. 8, 2019, 7:35 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71258/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2019, 7:35 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Tracked weight info in the Role struct in the allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 29dfa9f828f452b1aed8162c1e13f96d20907553
> src/master/allocator/mesos/hierarchical.cpp f1fa838d654816aba14ac032174bf1522b7ae033
>
>
> Diff: https://reviews.apache.org/r/71258/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 71258: Tracked weight info in the Role struct in
the allocator.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71258/#review217186
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Aug. 8, 2019, 7:35 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71258/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2019, 7:35 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Tracked weight info in the Role struct in the allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 29dfa9f828f452b1aed8162c1e13f96d20907553
> src/master/allocator/mesos/hierarchical.cpp f1fa838d654816aba14ac032174bf1522b7ae033
>
>
> Diff: https://reviews.apache.org/r/71258/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>