You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Dmitriy Shirchenko <ca...@gmail.com> on 2016/03/15 03:10:53 UTC
Review Request 44827: Do not split the shell command string passed
into shell health check script
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44827/
-----------------------------------------------------------
Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji.
Repository: aurora
Description
-------
Fixing bug where you could not pass in shell command into health checker with environment variables. When environment variable assignement was passed in, only that part would get executed and 0 would always get returned.
Diffs
-----
src/main/python/apache/aurora/common/health_check/shell.py bf63d936b3044dfa97a787938b643a52497f2d79
src/test/python/apache/aurora/common/health_check/test_shell.py 8d3a3e4e259e1ff699854aeb2434ac21f38e49ea
Diff: https://reviews.apache.org/r/44827/diff/
Testing
-------
Unit tests + end_to_end test.
Thanks,
Dmitriy Shirchenko
Re: Review Request 44827: Do not split the shell command string
passed into shell health check script
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44827/#review123744
-----------------------------------------------------------
Ship it!
Ship It!
- John Sirois
On March 14, 2016, 9:49 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44827/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 9:49 p.m.)
>
>
> Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-1633
> https://issues.apache.org/jira/browse/AURORA-1633
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing bug where you could not pass in shell command into health checker with environment variables. When environment variable assignement was passed in, only that part would get executed and 0 would always get returned.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/common/health_check/shell.py bf63d936b3044dfa97a787938b643a52497f2d79
> src/test/python/apache/aurora/common/health_check/test_shell.py 8d3a3e4e259e1ff699854aeb2434ac21f38e49ea
>
> Diff: https://reviews.apache.org/r/44827/diff/
>
>
> Testing
> -------
>
> Unit tests + end_to_end test.
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 44827: Do not split the shell command string
passed into shell health check script
Posted by Dmitriy Shirchenko <ca...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44827/
-----------------------------------------------------------
(Updated March 15, 2016, 3:49 a.m.)
Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji.
Bugs: AURORA-1633
https://issues.apache.org/jira/browse/AURORA-1633
Repository: aurora
Description
-------
Fixing bug where you could not pass in shell command into health checker with environment variables. When environment variable assignement was passed in, only that part would get executed and 0 would always get returned.
Diffs
-----
src/main/python/apache/aurora/common/health_check/shell.py bf63d936b3044dfa97a787938b643a52497f2d79
src/test/python/apache/aurora/common/health_check/test_shell.py 8d3a3e4e259e1ff699854aeb2434ac21f38e49ea
Diff: https://reviews.apache.org/r/44827/diff/
Testing
-------
Unit tests + end_to_end test.
Thanks,
Dmitriy Shirchenko
Re: Review Request 44827: Do not split the shell command string
passed into shell health check script
Posted by Zameer Manji <zm...@apache.org>.
> On March 14, 2016, 7:51 p.m., Bill Farner wrote:
> > Before i land this - can you file a bug and link against this patch? It will be helpful for release tracking and as a trail if anybody else bumps into this.
>
> Bill Farner wrote:
> s/i/we/, for some reason i thought i was the only reviewer.
+1
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44827/#review123578
-----------------------------------------------------------
On March 14, 2016, 7:10 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44827/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 7:10 p.m.)
>
>
> Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing bug where you could not pass in shell command into health checker with environment variables. When environment variable assignement was passed in, only that part would get executed and 0 would always get returned.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/common/health_check/shell.py bf63d936b3044dfa97a787938b643a52497f2d79
> src/test/python/apache/aurora/common/health_check/test_shell.py 8d3a3e4e259e1ff699854aeb2434ac21f38e49ea
>
> Diff: https://reviews.apache.org/r/44827/diff/
>
>
> Testing
> -------
>
> Unit tests + end_to_end test.
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 44827: Do not split the shell command string
passed into shell health check script
Posted by Bill Farner <wf...@apache.org>.
> On March 14, 2016, 7:51 p.m., Bill Farner wrote:
> > Before i land this - can you file a bug and link against this patch? It will be helpful for release tracking and as a trail if anybody else bumps into this.
s/i/we/, for some reason i thought i was the only reviewer.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44827/#review123578
-----------------------------------------------------------
On March 14, 2016, 7:10 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44827/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 7:10 p.m.)
>
>
> Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing bug where you could not pass in shell command into health checker with environment variables. When environment variable assignement was passed in, only that part would get executed and 0 would always get returned.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/common/health_check/shell.py bf63d936b3044dfa97a787938b643a52497f2d79
> src/test/python/apache/aurora/common/health_check/test_shell.py 8d3a3e4e259e1ff699854aeb2434ac21f38e49ea
>
> Diff: https://reviews.apache.org/r/44827/diff/
>
>
> Testing
> -------
>
> Unit tests + end_to_end test.
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 44827: Do not split the shell command string
passed into shell health check script
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44827/#review123578
-----------------------------------------------------------
Ship it!
Before i land this - can you file a bug and link against this patch? It will be helpful for release tracking and as a trail if anybody else bumps into this.
- Bill Farner
On March 14, 2016, 7:10 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44827/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 7:10 p.m.)
>
>
> Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing bug where you could not pass in shell command into health checker with environment variables. When environment variable assignement was passed in, only that part would get executed and 0 would always get returned.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/common/health_check/shell.py bf63d936b3044dfa97a787938b643a52497f2d79
> src/test/python/apache/aurora/common/health_check/test_shell.py 8d3a3e4e259e1ff699854aeb2434ac21f38e49ea
>
> Diff: https://reviews.apache.org/r/44827/diff/
>
>
> Testing
> -------
>
> Unit tests + end_to_end test.
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 44827: Do not split the shell command string
passed into shell health check script
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44827/#review123590
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On March 14, 2016, 7:10 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44827/
> -----------------------------------------------------------
>
> (Updated March 14, 2016, 7:10 p.m.)
>
>
> Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing bug where you could not pass in shell command into health checker with environment variables. When environment variable assignement was passed in, only that part would get executed and 0 would always get returned.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/common/health_check/shell.py bf63d936b3044dfa97a787938b643a52497f2d79
> src/test/python/apache/aurora/common/health_check/test_shell.py 8d3a3e4e259e1ff699854aeb2434ac21f38e49ea
>
> Diff: https://reviews.apache.org/r/44827/diff/
>
>
> Testing
> -------
>
> Unit tests + end_to_end test.
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
Re: Review Request 44827: Do not split the shell command string
passed into shell health check script
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44827/#review123592
-----------------------------------------------------------
Ship it!
Master (cbb206c) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On March 15, 2016, 2:10 a.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44827/
> -----------------------------------------------------------
>
> (Updated March 15, 2016, 2:10 a.m.)
>
>
> Review request for Aurora, John Sirois, Bill Farner, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fixing bug where you could not pass in shell command into health checker with environment variables. When environment variable assignement was passed in, only that part would get executed and 0 would always get returned.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/common/health_check/shell.py bf63d936b3044dfa97a787938b643a52497f2d79
> src/test/python/apache/aurora/common/health_check/test_shell.py 8d3a3e4e259e1ff699854aeb2434ac21f38e49ea
>
> Diff: https://reviews.apache.org/r/44827/diff/
>
>
> Testing
> -------
>
> Unit tests + end_to_end test.
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>