[GitHub] [cloudstack] rhtyd commented on a change in pull request #4389: Fixed vm-templates not being removed from primary storage with storag…

[GitBox <gi...@apache.org>]

rhtyd commented on a change in pull request #4389:
URL: https://github.com/apache/cloudstack/pull/4389#discussion_r500921115



##########
File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -6785,6 +6785,7 @@ public Answer execute(DestroyCommand cmd) {
                 if (s_logger.isInfoEnabled()) {
                     s_logger.info("Destroy template volume " + vol.getPath());
                 }
+                vmMo.markAsVirtualMachine(hyperHost.getHyperHostOwnerResourcePool(), hyperHost.getMor());

Review comment:
       @Spaceman1984 @sureshanaparti - in case of linked clones, it makes sense (the error). Do we/CloudStack check that template is not used by any of the VMs, prior to removing it. In that case it perfectly makes sense, if we don't delete the template from primary storage. Thoughts?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org