You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/09/09 13:42:21 UTC
[GitHub] [thrift] emmenlau opened a new pull request #2233: Added getter and setter for domain socket path
emmenlau opened a new pull request #2233:
URL: https://github.com/apache/thrift/pull/2233
This PR adds a minor change to C++ domain sockets. It adds a getter and setter for the domain socket path. Also, it adds a minor bugfix when printing abstract sockets. The zero-character prefix of abstract domain sockets needs to be converted to a printable character. It is typically printed as an `@`-sign.
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [x] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau commented on pull request #2233: Added getter and setter for domain socket path
Posted by GitBox <gi...@apache.org>.
emmenlau commented on pull request #2233:
URL: https://github.com/apache/thrift/pull/2233#issuecomment-691940842
The changes in this PR are pretty minimal, and should not have any negative side effects. Please consider for a quick review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau edited a comment on pull request #2233: Added getter and setter for domain socket path
Posted by GitBox <gi...@apache.org>.
emmenlau edited a comment on pull request #2233:
URL: https://github.com/apache/thrift/pull/2233#issuecomment-689726033
Checked, the build errors in Travis are all unrelated. Ready for review and merge...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2233: Added getter and setter for domain socket path
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2233:
URL: https://github.com/apache/thrift/pull/2233
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] emmenlau commented on pull request #2233: Added getter and setter for domain socket path
Posted by GitBox <gi...@apache.org>.
emmenlau commented on pull request #2233:
URL: https://github.com/apache/thrift/pull/2233#issuecomment-689726033
Checked, the build errors in Travis are all unrelated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org