You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/13 15:55:19 UTC
[GitHub] [flink] dixingxing0 opened a new pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
dixingxing0 opened a new pull request #14634:
URL: https://github.com/apache/flink/pull/14634
## What is the purpose of the change
This pull request improves HiveConf creation. see https://issues.apache.org/jira/browse/FLINK-20913
## Brief change log
Introduce HiveConfUtils to create HiveConf instance, avoid reset hive configuration to default value.
## Verifying this change
This change is already covered by existing tests, such as *(HiveTableSourceITCase)*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-759553978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"triggerType" : "PUSH"
}, {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "759896619",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 166b840d80a5b340ce0903b3255387cdfec3faf6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dixingxing0 commented on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
dixingxing0 commented on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-760749497
> Thanks @dixingxing0 for working on this. I've left some comments.
Thanks for the comments, I will address them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-759553978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"triggerType" : "PUSH"
}, {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "759896619",
"triggerType" : "MANUAL"
}, {
"hash" : "dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12115",
"triggerID" : "dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 166b840d80a5b340ce0903b3255387cdfec3faf6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002)
* dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12115)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-759542189
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a01de0515efdd96e388a8ee1cc299311f90ab07b (Fri May 28 07:10:38 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-759553978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"triggerType" : "PUSH"
}, {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "759896619",
"triggerType" : "MANUAL"
}, {
"hash" : "dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12115",
"triggerID" : "dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4",
"triggerType" : "PUSH"
}, {
"hash" : "a01de0515efdd96e388a8ee1cc299311f90ab07b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12116",
"triggerID" : "a01de0515efdd96e388a8ee1cc299311f90ab07b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12115)
* a01de0515efdd96e388a8ee1cc299311f90ab07b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12116)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-759553978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 166b840d80a5b340ce0903b3255387cdfec3faf6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-759553978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"triggerType" : "PUSH"
}, {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "759896619",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 166b840d80a5b340ce0903b3255387cdfec3faf6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-762643936
@dixingxing0 , could you also create pull requests for release-1.12 and release-1.11?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on a change in pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on a change in pull request #14634:
URL: https://github.com/apache/flink/pull/14634#discussion_r557980489
##########
File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/util/HiveConfUtilsTest.java
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive.util;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
+
+/** Test for {@link HiveConfUtils}. */
+public class HiveConfUtilsTest {
+ private static final String HIVE_SITE_CONTENT =
+ "<?xml version=\"1.0\"?>\n"
+ + "<?xml-stylesheet type=\"text/xsl\" href=\"configuration.xsl\"?>\n"
+ + "<configuration>\n"
+ + " <property>\n"
+ + " <name>hive.metastore.sasl.enabled</name>\n"
+ + " <value>true</value>\n"
+ + " </property>\n"
+ + "</configuration>\n";
+
+ @Test
+ public void test() {
Review comment:
Please give it a more meaningful name
##########
File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/util/HiveConfUtils.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive.util;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hive.conf.HiveConf;
+
+/** Create HiveConf. */
+public class HiveConfUtils {
+
+ /**
+ * Create HiveConf instance via hadoop configuration.
Review comment:
Please add more comments to explain why we need this util method
##########
File path: flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/util/HiveConfUtilsTest.java
##########
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.hive.util;
+
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.io.ByteArrayInputStream;
+import java.io.IOException;
+import java.io.InputStream;
+import java.nio.charset.StandardCharsets;
+
+/** Test for {@link HiveConfUtils}. */
+public class HiveConfUtilsTest {
+ private static final String HIVE_SITE_CONTENT =
+ "<?xml version=\"1.0\"?>\n"
+ + "<?xml-stylesheet type=\"text/xsl\" href=\"configuration.xsl\"?>\n"
+ + "<configuration>\n"
+ + " <property>\n"
+ + " <name>hive.metastore.sasl.enabled</name>\n"
+ + " <value>true</value>\n"
+ + " </property>\n"
+ + "</configuration>\n";
+
+ @Test
+ public void test() {
+ HiveConf hiveConf = createHiveConf();
+ Assert.assertTrue(hiveConf.getBoolVar(HiveConf.ConfVars.METASTORE_USE_THRIFT_SASL));
+
+ // will override configurations from `hiveConf` with hive default values which default value
+ // is null or empty string
+ HiveConf hiveConfNew = new HiveConf(hiveConf, HiveConf.class);
+ Assert.assertFalse(hiveConfNew.getBoolVar(HiveConf.ConfVars.METASTORE_USE_THRIFT_SASL));
+
+ hiveConfNew.addResource(hiveConf);
Review comment:
We should call `HiveConfUtils` to create another new HiveConf and verify the property is not overridden.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-759553978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"triggerType" : "PUSH"
}, {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "759896619",
"triggerType" : "MANUAL"
}, {
"hash" : "dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12115",
"triggerID" : "dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4",
"triggerType" : "PUSH"
}, {
"hash" : "a01de0515efdd96e388a8ee1cc299311f90ab07b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12116",
"triggerID" : "a01de0515efdd96e388a8ee1cc299311f90ab07b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a01de0515efdd96e388a8ee1cc299311f90ab07b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12116)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dixingxing0 edited a comment on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
dixingxing0 edited a comment on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-760749497
> Thanks @dixingxing0 for working on this. I've left some comments.
Thanks for the comments, I'm addressing them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dixingxing0 commented on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
dixingxing0 commented on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-762646954
> @dixingxing0 , could you also create pull requests for release-1.12 and release-1.11?
I would like to do that, i will submit the PR asap.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-759553978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 166b840d80a5b340ce0903b3255387cdfec3faf6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dixingxing0 edited a comment on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
dixingxing0 edited a comment on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-760749497
> Thanks @dixingxing0 for working on this. I've left some comments.
Thanks for the comments, I'am addressing them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-759553978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"triggerType" : "PUSH"
}, {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "759896619",
"triggerType" : "MANUAL"
}, {
"hash" : "dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 166b840d80a5b340ce0903b3255387cdfec3faf6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002)
* dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dixingxing0 edited a comment on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
dixingxing0 edited a comment on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-759896619
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-759553978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"triggerType" : "PUSH"
}, {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "759896619",
"triggerType" : "MANUAL"
}, {
"hash" : "dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12115",
"triggerID" : "dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4",
"triggerType" : "PUSH"
}, {
"hash" : "a01de0515efdd96e388a8ee1cc299311f90ab07b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a01de0515efdd96e388a8ee1cc299311f90ab07b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 166b840d80a5b340ce0903b3255387cdfec3faf6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002)
* dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12115)
* a01de0515efdd96e388a8ee1cc299311f90ab07b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dixingxing0 edited a comment on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
dixingxing0 edited a comment on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-760749497
> Thanks @dixingxing0 for working on this. I've left some comments.
Thanks for the comments, I'am addressing them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-759553978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 166b840d80a5b340ce0903b3255387cdfec3faf6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14634:
URL: https://github.com/apache/flink/pull/14634
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dixingxing0 commented on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
dixingxing0 commented on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-759896619
@flinkbot
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dixingxing0 commented on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
dixingxing0 commented on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-760877015
@lirui-apache I've adressed the comments, please take a look when you have spare time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-759542189
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 166b840d80a5b340ce0903b3255387cdfec3faf6 (Wed Jan 13 15:57:29 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-20913).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14634: [FLINK-20913][hive]Improve HiveConf creation
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14634:
URL: https://github.com/apache/flink/pull/14634#issuecomment-759553978
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"triggerType" : "PUSH"
}, {
"hash" : "166b840d80a5b340ce0903b3255387cdfec3faf6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002",
"triggerID" : "759896619",
"triggerType" : "MANUAL"
}, {
"hash" : "dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12115",
"triggerID" : "dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4",
"triggerType" : "PUSH"
}, {
"hash" : "a01de0515efdd96e388a8ee1cc299311f90ab07b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12116",
"triggerID" : "a01de0515efdd96e388a8ee1cc299311f90ab07b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 166b840d80a5b340ce0903b3255387cdfec3faf6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12002)
* dfad170401c7a97ed51e8e419ca1a73d0ee5f9a4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12115)
* a01de0515efdd96e388a8ee1cc299311f90ab07b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12116)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org