[GitHub] [arrow-adbc] pitrou commented on a diff in pull request #692: feat(format): introduce ADBC API revision 1.1.0

["pitrou (via GitHub)" <gi...@apache.org>]

pitrou commented on code in PR #692:
URL: https://github.com/apache/arrow-adbc/pull/692#discussion_r1205987167


##########
c/driver_manager/adbc_driver_manager.cc:
##########
@@ -781,12 +810,17 @@ AdbcStatusCode AdbcLoadDriverFromInitFunc(AdbcDriverInitFunc init_func, int vers
     return ADBC_STATUS_INTERNAL;                                               \
   }
 
-  auto result = init_func(version, raw_driver, error);
+  AdbcStatusCode result = ADBC_STATUS_NOT_IMPLEMENTED;
+  for (const int try_version : kSupportedVersions) {
+    if (try_version > version) continue;

Review Comment:
   I'm trying to understand the logic. Does it mean that, if the user passes a future `ADBC_VERSION_1_2_0`, we try calling `init_func` with `ADBC_VERSION_1_1_0` and then with `ADBC_VERSION_1_0_0`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org