[jira] [Commented] (HUDI-515) Resolve API conflict for Hive 2 and Hive 3

["Nishith Agarwal (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HUDI-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012405#comment-17012405 ] 

Nishith Agarwal commented on HUDI-515:
--------------------------------------

[~wenningd] Most of the code of *HoodieCombineHiveInputFormat.java* is a reflection of open source code due to lack of easy ways to extend these hive classes. I'm fine with copying source code from [HiveFileFormatUtils.getFromPathRecursively()|https://github.com/apache/hive/blob/release-3.1.2-rc0/ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java] to make Hive 3 work but we need to make it backwards compatible with Hive 2. You may have to use a flag with an if-else method and compile accordingly. 

> Resolve API conflict for Hive 2 and Hive 3
> ------------------------------------------
>
>                 Key: HUDI-515
>                 URL: https://issues.apache.org/jira/browse/HUDI-515
>             Project: Apache Hudi (incubating)
>          Issue Type: Sub-task
>            Reporter: Wenning Ding
>            Priority: Major
>
> Currently I am working on supporting HIVE 3. There is an API issue.
> In *HoodieCombineHiveInputFormat.java*, it calls a Hive method: HiveFileFormatUtils.getPartitionDescFromPathRecursively(). But this method is removed in Hive 3 and replaced by HiveFileFormatUtils.getFromPathRecursively().
> Ideally, Hudi should support both Hive 2 & Hive 3 so that both
> {code:java}
> mvn clean install{code}
> and
> {code:java}
> mvn clean install -Dhive.version=3.x{code}
> could work.
> One solution is to directly copy source code from [HiveFileFormatUtils.getFromPathRecursively()|https://github.com/apache/hive/blob/release-3.1.2-rc0/ql/src/java/org/apache/hadoop/hive/ql/io/HiveFileFormatUtils.java] and put that code inside *HoodieCombineHiveInputFormat.java*.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)