You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brooklyn.apache.org by rdowner <gi...@git.apache.org> on 2018/01/08 12:05:05 UTC

[GitHub] brooklyn-server pull request #926: [WIP] remove PortableTemplateBuilder

Github user rdowner commented on a diff in the pull request:

    https://github.com/apache/brooklyn-server/pull/926#discussion_r160126361
  
    --- Diff: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java ---
    @@ -2609,7 +2609,7 @@ protected LoginCredentials waitForSshable(
         protected LoginCredentials waitForSshable(
                 HostAndPort hostAndPort, Iterable<LoginCredentials> credentialsToTry, ConfigBag setup) {
             String waitForSshable = setup.get(WAIT_FOR_SSHABLE);
    -        checkArgument(!"false".equalsIgnoreCase(waitForSshable), "waitForSshable called despite waitForSshable=%s for %s", waitForSshable, hostAndPort);
    +//        checkArgument(!"false".equalsIgnoreCase(waitForSshable), "waitForSshable called despite waitForSshable=%s for %s", waitForSshable, hostAndPort);
    --- End diff --
    
    Please avoid committing commented-out lines of code. Is this line supposed to be deleted, or was it commented out to help debugging?


---