[GitHub] [superset] rusackas commented on pull request #17796: feat: Create D3NumberFormatters with active Locale

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #17796:
URL: https://github.com/apache/superset/pull/17796#issuecomment-1535007535

   @hbruch we just merged https://github.com/apache/superset/pull/20075, and after discussion with others, we think using the browser locale is more dangerous than helpful (i.e. if you're browsing from the UK, you don't want to see columns of Yen displayed as Pounds :) I'm tempted to close this, but open to further discussion here or on Slack if you feel differently. Thanks either way for the thought/initiative/work on this PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org