[GitHub] [solr] dweiss commented on a change in pull request #275: SOLR-15602: upgrade to gradle 7.2, clean up gradle code a bit.

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #275:
URL: https://github.com/apache/solr/pull/275#discussion_r699602425



##########
File path: build.gradle
##########
@@ -183,6 +184,7 @@ apply from: file('gradle/hacks/solr.findbugs.gradle')
 apply from: file('gradle/hacks/wipe-temp.gradle')
 apply from: file('gradle/hacks/hashmapAssertions.gradle')
 apply from: file('gradle/hacks/turbocharge-jvm-opts.gradle')
+apply from: file('gradle/hacks/dummy-outputs.gradle')

Review comment:
       I'd rather keep it consistent with Lucene, if you don't mind. Not a native speaker but is something wrong with the "dummy"? I am aware of other senses but this literal definition suits me just fine in this context "an object designed to resemble and serve as a substitute for the real or usual one."?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org