You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by da...@apache.org on 2014/01/17 23:57:11 UTC

[07/50] git commit: Fix suspected bug in PLAINTEXT signature.

Fix suspected bug in PLAINTEXT signature.

This JavaScript implementation:
http://oauth.googlecode.com/svn/code/javascript/oauth.js appears to
indicate that the signature only needs to be encoded once, not twice.
This makes erlang-oauth comply, assuming it is passed an already-decoded
signature to verify (which is usual when using something like Mochiweb,
for example).

Signed-off-by: Tim Fletcher <ti...@tfletcher.com>

Project: http://git-wip-us.apache.org/repos/asf/couchdb-oauth/repo
Commit: http://git-wip-us.apache.org/repos/asf/couchdb-oauth/commit/56259760
Tree: http://git-wip-us.apache.org/repos/asf/couchdb-oauth/tree/56259760
Diff: http://git-wip-us.apache.org/repos/asf/couchdb-oauth/diff/56259760

Branch: refs/heads/import
Commit: 562597602b054f8e2412ff54d7957839aa88c2c5
Parents: 5d93e6b
Author: Jason Davies <ja...@jdd.local>
Authored: Tue Jul 14 05:59:42 2009 +0800
Committer: Tim Fletcher <ti...@tfletcher.com>
Committed: Mon Jul 20 01:43:30 2009 +0800

----------------------------------------------------------------------
 src/oauth_plaintext.erl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/couchdb-oauth/blob/56259760/src/oauth_plaintext.erl
----------------------------------------------------------------------
diff --git a/src/oauth_plaintext.erl b/src/oauth_plaintext.erl
index 1aae8fc..d8085e0 100644
--- a/src/oauth_plaintext.erl
+++ b/src/oauth_plaintext.erl
@@ -4,7 +4,7 @@
 
 
 signature(CS, TS) ->
-  oauth_uri:encode(oauth_uri:calate("&", [CS, TS])).
+  oauth_uri:calate("&", [CS, TS]).
 
 verify(Signature, CS, TS) ->
   Signature =:= signature(CS, TS).