You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/11/17 15:29:21 UTC
[GitHub] [ignite-3] sashapolo opened a new pull request, #1354: IGNITE-18063 Use consistent IDs in assignments
sashapolo opened a new pull request, #1354:
URL: https://github.com/apache/ignite-3/pull/1354
https://issues.apache.org/jira/browse/IGNITE-18063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1354: IGNITE-18063 Use consistent IDs in assignments
Posted by GitBox <gi...@apache.org>.
ibessonov commented on code in PR #1354:
URL: https://github.com/apache/ignite-3/pull/1354#discussion_r1026122117
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/message/MessageListener.java:
##########
@@ -27,8 +27,8 @@ public interface MessageListener {
/**
* OnMessage.
*
- * @param nodeId Sender node ID.
+ * @param nodeName Sender node consistent ID.
* @param msg Message.
Review Comment:
```suggestion
* @param msg Message.
```
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/Outbox.java:
##########
@@ -95,15 +95,15 @@ public long exchangeId() {
/**
* Callback method.
*
- * @param nodeId Target ID.
+ * @param nodeName Target consistent ID.
Review Comment:
```suggestion
* @param nodeName Target consistent ID.
```
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/metadata/RemoteException.java:
##########
@@ -34,22 +34,22 @@ public class RemoteException extends RuntimeException {
* Constructor.
*
* @param cause Cause.
- * @param nodeId Node ID.
+ * @param nodeName Node consistent ID.
Review Comment:
```suggestion
* @param nodeName Node consistent ID.
```
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/metadata/RemoteException.java:
##########
@@ -34,22 +34,22 @@ public class RemoteException extends RuntimeException {
* Constructor.
*
* @param cause Cause.
- * @param nodeId Node ID.
+ * @param nodeName Node consistent ID.
Review Comment:
Please format other lines too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] ibessonov merged pull request #1354: IGNITE-18063 Use consistent IDs in assignments
Posted by GitBox <gi...@apache.org>.
ibessonov merged PR #1354:
URL: https://github.com/apache/ignite-3/pull/1354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org