You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/10/11 13:52:05 UTC
[GitHub] [solr] gerlowskija opened a new pull request, #1065: SOLR-16392: Minor CollectionsHandler cleanup
gerlowskija opened a new pull request, #1065:
URL: https://github.com/apache/solr/pull/1065
https://issues.apache.org/jira/browse/SOLR-16392
# Description
CollectionsHandler.handleRequestBody had an unnecessary switch-case statement that cluttered thing up, instead of leaning on the CollectionsOperation enum already present for this purpose.
# Solution
This PR removes the switch-case in favor of using CollectionOperation as was done previously. Credit for Bruno R for the suggestion.
# Tests
No new tests added for this minor refactor. Existing tests continue to pass.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] sonatype-lift[bot] commented on pull request #1065: SOLR-16392: Minor CollectionsHandler cleanup
Posted by GitBox <gi...@apache.org>.
sonatype-lift[bot] commented on PR #1065:
URL: https://github.com/apache/solr/pull/1065#issuecomment-1274815855
:warning: **314 God Classes** were detected by Lift in this project. [Visit the Lift web console](https://lift.sonatype.com/results/github.com/apache/solr/01GF3N26Q844E15AF1AWRH9T8H?tab=technical-debt&utm_source=github.com&utm_campaign=lift-comment&utm_content=apache\%20solr) for more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija merged pull request #1065: SOLR-16392: Minor CollectionsHandler cleanup
Posted by GitBox <gi...@apache.org>.
gerlowskija merged PR #1065:
URL: https://github.com/apache/solr/pull/1065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] gerlowskija commented on pull request #1065: SOLR-16392: Minor CollectionsHandler cleanup
Posted by GitBox <gi...@apache.org>.
gerlowskija commented on PR #1065:
URL: https://github.com/apache/solr/pull/1065#issuecomment-1274797954
Still waiting on some tests running locally, but will merge when those finish up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org