You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sr...@apache.org on 2016/12/24 13:03:03 UTC
spark git commit: [SPARK-18837][WEBUI] Very long stage descriptions
do not wrap in the UI
Repository: spark
Updated Branches:
refs/heads/master 07fcbea51 -> f2ceb2abe
[SPARK-18837][WEBUI] Very long stage descriptions do not wrap in the UI
## What changes were proposed in this pull request?
This issue was reported by wangyum.
In the AllJobsPage, JobPage and StagePage, the description length was limited before like as follows.
But recently, the limitation seems to have been accidentally removed.
The cause is that some tables are no longer `sortable` class although they were, and `sortable` class does not only mark tables as sortable but also limited the width of their child `td` elements.
The reason why now some tables are not `sortable` class is because another sortable mechanism was introduced by #13620 and #13708 with pagination feature.
To fix this issue, I've introduced new class `table-cell-width-limited` which limits the description cell width and the description is like what it was.
<img width="1260" alt="2016-12-20 1 00 34" src="https://cloud.githubusercontent.com/assets/4736016/21320478/89141c7a-c654-11e6-8494-f8f91325980b.png">
## How was this patch tested?
Tested manually with my browser.
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Closes #16338 from sarutak/SPARK-18837.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/f2ceb2ab
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/f2ceb2ab
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/f2ceb2ab
Branch: refs/heads/master
Commit: f2ceb2abe9357942a51bd643683850efd1fc9df7
Parents: 07fcbea
Author: Kousuke Saruta <sa...@oss.nttdata.co.jp>
Authored: Sat Dec 24 13:02:58 2016 +0000
Committer: Sean Owen <so...@cloudera.com>
Committed: Sat Dec 24 13:02:58 2016 +0000
----------------------------------------------------------------------
core/src/main/resources/org/apache/spark/ui/static/webui.css | 4 ++++
core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala | 3 ++-
core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala | 3 ++-
3 files changed, 8 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/f2ceb2ab/core/src/main/resources/org/apache/spark/ui/static/webui.css
----------------------------------------------------------------------
diff --git a/core/src/main/resources/org/apache/spark/ui/static/webui.css b/core/src/main/resources/org/apache/spark/ui/static/webui.css
index b157f3e..319a719 100644
--- a/core/src/main/resources/org/apache/spark/ui/static/webui.css
+++ b/core/src/main/resources/org/apache/spark/ui/static/webui.css
@@ -246,4 +246,8 @@ a.expandbutton {
text-align: center;
margin: 0;
padding: 4px 0;
+}
+
+.table-cell-width-limited td {
+ max-width: 600px;
}
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/spark/blob/f2ceb2ab/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala b/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
index 50e8e2d..d217f55 100644
--- a/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
+++ b/core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala
@@ -500,7 +500,8 @@ private[ui] class JobPagedTable(
override def tableId: String = jobTag + "-table"
override def tableCssClass: String =
- "table table-bordered table-condensed table-striped table-head-clickable"
+ "table table-bordered table-condensed table-striped " +
+ "table-head-clickable table-cell-width-limited"
override def pageSizeFormField: String = jobTag + ".pageSize"
http://git-wip-us.apache.org/repos/asf/spark/blob/f2ceb2ab/core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala
----------------------------------------------------------------------
diff --git a/core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala b/core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala
index c9d0431..e1fa904 100644
--- a/core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala
+++ b/core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala
@@ -149,7 +149,8 @@ private[ui] class StagePagedTable(
override def tableId: String = stageTag + "-table"
override def tableCssClass: String =
- "table table-bordered table-condensed table-striped table-head-clickable"
+ "table table-bordered table-condensed table-striped " +
+ "table-head-clickable table-cell-width-limited"
override def pageSizeFormField: String = stageTag + ".pageSize"
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org