You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@metron.apache.org by GitBox <gi...@apache.org> on 2019/02/13 23:01:48 UTC

[GitHub] nickwallen commented on a change in pull request #1305: METRON-1940:Check if not and install Elastic search templates / Solr collections when indexing server is restarted

nickwallen commented on a change in pull request #1305: METRON-1940:Check if not and install Elastic search templates / Solr collections when indexing server is restarted
URL: https://github.com/apache/metron/pull/1305#discussion_r256627166
 
 

 ##########
 File path: metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/package/scripts/indexing_master.py
 ##########
 @@ -119,6 +119,10 @@ def start(self, env, upgrade_type=None):
                 msg = "WARNING: Elasticsearch index templates could not be installed.  " \
 
 Review comment:
   Can we move this try/catch block into `elasticsearch_template_install`?  Then it doesn't have to be duplicated in `start` and `restart`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services