You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2020/01/06 10:07:38 UTC

[Impala-ASF-CR] IMPALA-9278 Fix error:expected primary-expression before ‘return’

huangtianhua223@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14978


Change subject: IMPALA-9278 Fix error:expected primary-expression before ‘return’
......................................................................

IMPALA-9278 Fix error:expected primary-expression before ‘return’

Change-Id: I8530fe7b59f7fa0c989d0f4a8f91279e203b0cf1
---
M be/src/gutil/atomicops-internals-x86.h
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/14978/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14978
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8530fe7b59f7fa0c989d0f4a8f91279e203b0cf1
Gerrit-Change-Number: 14978
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>

[Impala-ASF-CR] IMPALA-9278 Fix error:expected primary-expression before ‘return’

Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14978 )

Change subject: IMPALA-9278 Fix error:expected primary-expression before ‘return’
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14978
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8530fe7b59f7fa0c989d0f4a8f91279e203b0cf1
Gerrit-Change-Number: 14978
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jan 2020 06:04:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9278 Fix error:expected primary-expression before ‘return’

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14978 )

Change subject: IMPALA-9278 Fix error:expected primary-expression before ‘return’
......................................................................

IMPALA-9278 Fix error:expected primary-expression before ‘return’

Change-Id: I8530fe7b59f7fa0c989d0f4a8f91279e203b0cf1
Reviewed-on: http://gerrit.cloudera.org:8080/14978
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/gutil/atomicops-internals-x86.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Tim Armstrong: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14978
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8530fe7b59f7fa0c989d0f4a8f91279e203b0cf1
Gerrit-Change-Number: 14978
Gerrit-PatchSet: 2
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9278 Fix error:expected primary-expression before ‘return’

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14978 )

Change subject: IMPALA-9278 Fix error:expected primary-expression before ‘return’
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5379/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/14978
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8530fe7b59f7fa0c989d0f4a8f91279e203b0cf1
Gerrit-Change-Number: 14978
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jan 2020 06:04:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9278 Fix error:expected primary-expression before ‘return’

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14978 )

Change subject: IMPALA-9278 Fix error:expected primary-expression before ‘return’
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14978
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8530fe7b59f7fa0c989d0f4a8f91279e203b0cf1
Gerrit-Change-Number: 14978
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jan 2020 10:41:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9278 Fix error:expected primary-expression before ‘return’

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14978 )

Change subject: IMPALA-9278 Fix error:expected primary-expression before ‘return’
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5365/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14978
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8530fe7b59f7fa0c989d0f4a8f91279e203b0cf1
Gerrit-Change-Number: 14978
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jan 2020 10:37:31 +0000
Gerrit-HasComments: No