You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "morhidi (via GitHub)" <gi...@apache.org> on 2023/07/26 17:14:14 UTC
[GitHub] [flink-kubernetes-operator] morhidi opened a new pull request, #639: [FLINK-32690] report Double.NAN instead of null for missing autoscaler metrics
morhidi opened a new pull request, #639:
URL: https://github.com/apache/flink-kubernetes-operator/pull/639
## What is the purpose of the change
Change null values to Double.NAN for autoscaler metrics during blackout periods when no data is gathered. This appears to be a more common practice then null. Also consistent with other metrics we have.
## Brief change log
This is a minor fix in `AutoscalerFlinkMetrics`
## Verifying this change
Manually + Unit tests
```
resource.default.autoscaling-example.FlinkDeployment.AutoScaler.jobVertexID.cbc357ccb763df2852fee8c4fc7d55f2.RECOMMENDED_PARALLELISM.Current: NaN
resource.default.autoscaling-example.FlinkDeployment.AutoScaler.jobVertexID.90bea66de1c231edf33913ecd54406c1.RECOMMENDED_PARALLELISM.Current: NaN
resource.default.autoscaling-example.FlinkDeployment.AutoScaler.jobVertexID.cbc357ccb763df2852fee8c4fc7d55f2.MAX_PARALLELISM.Current: NaN
resource.default.autoscaling-example.FlinkDeployment.AutoScaler.jobVertexID.90bea66de1c231edf33913ecd54406c1.CATCH_UP_DATA_RATE.Current: NaN
resource.default.autoscaling-example.FlinkDeployment.AutoScaler.jobVertexID.cbc357ccb763df2852fee8c4fc7d55f2.PARALLELISM.Current: NaN
resource.default.autoscaling-example.FlinkDeployment.AutoScaler.jobVertexID.90bea66de1c231edf33913ecd54406c1.TRUE_PROCESSING_RATE.Average: NaN
resource.default.autoscaling-example.FlinkDeployment.AutoScaler.jobVertexID.cbc357ccb763df2852fee8c4fc7d55f2.CATCH_UP_DATA_RATE.Current: NaN
resource.default.autoscaling-example.FlinkDeployment.AutoScaler.jobVertexID.90bea66de1c231edf33913ecd54406c1.MAX_PARALLELISM.Current: NaN
system.FlinkDeployment.Lifecycle.State.CREATED.TimeSeconds: count=0, min=0, max=0, mean=NaN, stddev=NaN, p50=NaN, p75=NaN, p95=NaN, p98=NaN, p99=NaN, p999=NaN
system.FlinkDeployment.Lifecycle.State.ROLLING_BACK.TimeSeconds: count=0, min=0, max=0, mean=NaN, stddev=NaN, p50=NaN, p75=NaN, p95=NaN, p98=NaN, p99=NaN, p999=NaN
namespace.default.FlinkDeployment.Lifecycle.State.STABLE.TimeSeconds: count=0, min=0, max=0, mean=NaN, stddev=NaN, p50=NaN, p75=NaN, p95=NaN, p98=NaN, p99=NaN, p999=NaN
namespace.default.FlinkDeployment.Lifecycle.State.ROLLING_BACK.TimeSeconds: count=0, min=0, max=0, mean=NaN, stddev=NaN, p50=NaN, p75=NaN, p95=NaN, p98=NaN, p99=NaN, p999=NaN
```
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`: no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #639: [FLINK-32690] report Double.NAN instead of null for missing autoscaler metrics
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora commented on PR #639:
URL: https://github.com/apache/flink-kubernetes-operator/pull/639#issuecomment-1652453972
cc @mxm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #639: [FLINK-32690] report Double.NAN instead of null for missing autoscaler metrics
Posted by "gyfora (via GitHub)" <gi...@apache.org>.
gyfora merged PR #639:
URL: https://github.com/apache/flink-kubernetes-operator/pull/639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org