You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/12/06 18:33:00 UTC
[jira] [Work logged] (BEAM-8911) Upgrade Guava to 25
[ https://issues.apache.org/jira/browse/BEAM-8911?focusedWorklogId=355373&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-355373 ]
ASF GitHub Bot logged work on BEAM-8911:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Dec/19 18:32
Start Date: 06/Dec/19 18:32
Worklog Time Spent: 10m
Work Description: suztomo commented on pull request #10318: [BEAM-8911] New non-vendored Guava version: 25.1-jre
URL: https://github.com/apache/beam/pull/10318
https://issues.apache.org/jira/browse/BEAM-8911
Now unused non-vendored Guava dependencies are removed ([BEAM-8747](https://issues.apache.org/jira/browse/BEAM-8747)) and Hadoop client version is upgraded to 2.8.5 from 2.7 ([BEAM-8822](https://issues.apache.org/jira/browse/BEAM-8822)). It's time to upgrade Guava.
# New Guava version: 25.1-jre
CharMatcher.DIGIT, used by org.apache.cassandra.io.sstable.format.SSTableFormat, is removed since Guava 26.0. 25.1 is the latest version:
https://guava.dev/releases/25.1-jre/api/docs/com/google/common/base/CharMatcher.html
https://guava.dev/releases/26.0-jre/api/docs/com/google/common/base/CharMatcher.html
Guava has 2 variations "-jre" for Java8 (stream/lambda support) and "-android" for Java7. Gcsio:1.9.16, which Beam has not have in dependency tree yet, needs ImmutableSet.toImmutableSet() which is available in Guava "-jre". [detail](https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1028#issuecomment-55768092)
# Which modules use non-vendored Guava?
```
suztomo@suxtomo24:~/beam6$ find . -name build.gradle | xargs grep library.java.guava
./sdks/java/core/build.gradle: shadowTest library.java.guava_testlib
./sdks/java/io/google-cloud-platform/build.gradle: compile library.java.guava
./sdks/java/io/kinesis/build.gradle: compile library.java.guava
./sdks/java/io/kinesis/build.gradle: testCompile library.java.guava_testlib
./sdks/java/extensions/sql/zetasql/build.gradle: compile library.java.guava
```
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 355373)
Remaining Estimate: 0h
Time Spent: 10m
> Upgrade Guava to 25
> -------------------
>
> Key: BEAM-8911
> URL: https://issues.apache.org/jira/browse/BEAM-8911
> Project: Beam
> Issue Type: Improvement
> Components: build-system
> Reporter: Tomo Suzuki
> Assignee: Tomo Suzuki
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Now [BEAM-8822] Hadoop client version 2.8.5 from 2.7 is merged. It's time to upgrade Guava.
> h1. New Guava version: 25.1-jre
> CharMatcher.DIGIT, used by org.apache.cassandra.io.sstable.format.SSTableFormat, is removed since Guava 26.0. 25.1 is the latest version:
> https://guava.dev/releases/25.1-jre/api/docs/com/google/common/base/CharMatcher.html
> https://guava.dev/releases/26.0-jre/api/docs/com/google/common/base/CharMatcher.html
> Guava has 2 variations "-jre" for Java8 (stream/lambda support) and "-android" for Java7. Gcsio:1.9.16, which Beam has not have in dependency tree yet, needs ImmutableSet.toImmutableSet() which is available in Guava "-jre".
> https://github.com/GoogleCloudPlatform/cloud-opensource-java/issues/1028#issuecomment-557680928
> h2. What about upgrading Cassandra-all?
> The latest cassandra-all release is "4.0-alpha2", which is still alpha.
> Non-alpha version is 3.11.5 https://search.maven.org/artifact/org.apache.cassandra/cassandra-all/3.11.5/jar, which still relies on Guava 19 and it still has reference to DIGIT:
> {noformat}
> suztomo@suxtomo24:~/grpc-java$ javap -v -cp ~/Downloads/cassandra-all-3.11.5.jar 'org.apache.cassandra.io.sstable.format.SSTableFormat$Type' |grep DIGIT
> #9 = Fieldref #79.#80 // com/google/common/base/CharMatcher.DIGIT:Lcom/google/common/base/CharMatcher;
> #80 = NameAndType #110:#111 // DIGIT:Lcom/google/common/base/CharMatcher;
> #110 = Utf8 DIGIT
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)