You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/04 00:02:13 UTC

[GitHub] [arrow] lidavidm commented on a diff in pull request #13039: ARROW-16428: [Release] Add prefix to ENV variables

lidavidm commented on code in PR #13039:
URL: https://github.com/apache/arrow/pull/13039#discussion_r864342770


##########
dev/release/verify-release-candidate.sh:
##########
@@ -982,8 +982,8 @@ test_linux_wheels() {
     local pyver=${python/m}
     for platform in ${platform_tags}; do
       show_header "Testing Python ${pyver} wheel for platform ${platform}"
-      ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_conda || exit 1
-      ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_virtualenv || continue
+      VENV_ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setup_conda || exit 1

Review Comment:
   Should this be CONDA_ENV here and on L1016 below? I was having trouble verifying wheels until I changed this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org