You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/11/10 05:28:23 UTC
[GitHub] [hive] pkumarsinha opened a new pull request #1657: HIVE-24363: Current order of transactional event listeners is prone t…
pkumarsinha opened a new pull request #1657:
URL: https://github.com/apache/hive/pull/1657
…o deadlock in backend DB connections
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha commented on a change in pull request #1657: HIVE-24363: Current order of transactional event listeners is prone t…
Posted by GitBox <gi...@apache.org>.
pkumarsinha commented on a change in pull request #1657:
URL: https://github.com/apache/hive/pull/1657#discussion_r521492511
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -571,9 +571,12 @@ public void init() throws MetaException {
listeners = MetaStoreServerUtils.getMetaStoreListeners(MetaStoreEventListener.class, conf,
MetastoreConf.getVar(conf, ConfVars.EVENT_LISTENERS));
listeners.add(new SessionPropertiesListener(conf));
- transactionalListeners = MetaStoreServerUtils.getMetaStoreListeners(TransactionalMetaStoreEventListener.class,
- conf, MetastoreConf.getVar(conf, ConfVars.TRANSACTIONAL_EVENT_LISTENERS));
- transactionalListeners.add(new AcidEventListener(conf));
+ transactionalListeners = new ArrayList() {{
Review comment:
@pgaref Thanks for the review.
Currently, there are just two impl for transnational event listener in Hive . Out of that, AcidEventLisner is hard-coded to be included. The other one, DbNotificationListener is the one which will ideally end up getting configured if user choose to do so. So the idea was, unless a user writes a custom transnational event listener, this config can have at most one value as of now. Let me know your opinion with this context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha commented on a change in pull request #1657: HIVE-24363: Current order of transactional event listeners is prone t…
Posted by GitBox <gi...@apache.org>.
aasha commented on a change in pull request #1657:
URL: https://github.com/apache/hive/pull/1657#discussion_r520298358
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -573,7 +573,7 @@ public void init() throws MetaException {
listeners.add(new SessionPropertiesListener(conf));
transactionalListeners = MetaStoreServerUtils.getMetaStoreListeners(TransactionalMetaStoreEventListener.class,
conf, MetastoreConf.getVar(conf, ConfVars.TRANSACTIONAL_EVENT_LISTENERS));
- transactionalListeners.add(new AcidEventListener(conf));
+ transactionalListeners.add(0, new AcidEventListener(conf));
Review comment:
Since you already know this has to be at the 0th index, you can add this at the beginning instead of shifting all other listeners and adding this to 0th index later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #1657: HIVE-24363: Current order of transactional event listeners is prone t…
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #1657:
URL: https://github.com/apache/hive/pull/1657#discussion_r521470008
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
##########
@@ -1216,8 +1216,10 @@ public static ConfVars getMetaConf(String name) {
"Can notification events from notification log table be used for updating the metastore cache."),
TRANSACTIONAL_EVENT_LISTENERS("metastore.transactional.event.listeners",
"hive.metastore.transactional.event.listeners", "",
- "A comma separated list of Java classes that implement the org.apache.riven.MetaStoreEventListener" +
- " interface. Both the metastore event and corresponding listener method will be invoked in the same JDO transaction."),
+ "A comma separated list of Java classes that implement the org.apache.riven.MetaStoreEventListener interface." +
+ " Both the metastore event and corresponding listener method will be invoked in the same JDO transaction." +
+ " If DbNotificationListener is configured along with other transactional event listenr, make sure it is" +
Review comment:
listenr -> listener
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #1657: HIVE-24363: Current order of transactional event listeners is prone t…
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #1657:
URL: https://github.com/apache/hive/pull/1657#discussion_r521472364
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -571,9 +571,12 @@ public void init() throws MetaException {
listeners = MetaStoreServerUtils.getMetaStoreListeners(MetaStoreEventListener.class, conf,
MetastoreConf.getVar(conf, ConfVars.EVENT_LISTENERS));
listeners.add(new SessionPropertiesListener(conf));
- transactionalListeners = MetaStoreServerUtils.getMetaStoreListeners(TransactionalMetaStoreEventListener.class,
- conf, MetastoreConf.getVar(conf, ConfVars.TRANSACTIONAL_EVENT_LISTENERS));
- transactionalListeners.add(new AcidEventListener(conf));
+ transactionalListeners = new ArrayList() {{
Review comment:
Hey @pkumarsinha thanks for the PR -- along the same lines as @aasha , would it make sense to have have some checks in place ensuring some order depending on the Listener type instead of just relying on the user (who will highly likely ignore the conf comment you added above)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha commented on a change in pull request #1657: HIVE-24363: Current order of transactional event listeners is prone t…
Posted by GitBox <gi...@apache.org>.
aasha commented on a change in pull request #1657:
URL: https://github.com/apache/hive/pull/1657#discussion_r520299449
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -573,7 +573,7 @@ public void init() throws MetaException {
listeners.add(new SessionPropertiesListener(conf));
transactionalListeners = MetaStoreServerUtils.getMetaStoreListeners(TransactionalMetaStoreEventListener.class,
conf, MetastoreConf.getVar(conf, ConfVars.TRANSACTIONAL_EVENT_LISTENERS));
- transactionalListeners.add(new AcidEventListener(conf));
+ transactionalListeners.add(0, new AcidEventListener(conf));
Review comment:
Also how do you make sure that notification event listener is added to the end?
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -573,7 +573,7 @@ public void init() throws MetaException {
listeners.add(new SessionPropertiesListener(conf));
transactionalListeners = MetaStoreServerUtils.getMetaStoreListeners(TransactionalMetaStoreEventListener.class,
conf, MetastoreConf.getVar(conf, ConfVars.TRANSACTIONAL_EVENT_LISTENERS));
- transactionalListeners.add(new AcidEventListener(conf));
+ transactionalListeners.add(0, new AcidEventListener(conf));
Review comment:
Good to add a test for the same
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha commented on a change in pull request #1657: HIVE-24363: Current order of transactional event listeners is prone t…
Posted by GitBox <gi...@apache.org>.
aasha commented on a change in pull request #1657:
URL: https://github.com/apache/hive/pull/1657#discussion_r520327915
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -573,7 +573,7 @@ public void init() throws MetaException {
listeners.add(new SessionPropertiesListener(conf));
transactionalListeners = MetaStoreServerUtils.getMetaStoreListeners(TransactionalMetaStoreEventListener.class,
conf, MetastoreConf.getVar(conf, ConfVars.TRANSACTIONAL_EVENT_LISTENERS));
- transactionalListeners.add(new AcidEventListener(conf));
+ transactionalListeners.add(0, new AcidEventListener(conf));
Review comment:
Test to make sure notification listener is the last listener. How do you make sure that notification event listener is added to the end in current code?
The listener list maybe small now but can grow in the future. Wouldn't recommend adding a known overhead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha commented on a change in pull request #1657: HIVE-24363: Current order of transactional event listeners is prone t…
Posted by GitBox <gi...@apache.org>.
pkumarsinha commented on a change in pull request #1657:
URL: https://github.com/apache/hive/pull/1657#discussion_r520302499
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -573,7 +573,7 @@ public void init() throws MetaException {
listeners.add(new SessionPropertiesListener(conf));
transactionalListeners = MetaStoreServerUtils.getMetaStoreListeners(TransactionalMetaStoreEventListener.class,
conf, MetastoreConf.getVar(conf, ConfVars.TRANSACTIONAL_EVENT_LISTENERS));
- transactionalListeners.add(new AcidEventListener(conf));
+ transactionalListeners.add(0, new AcidEventListener(conf));
Review comment:
Can you suggest the test what you are expecting to cover?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha commented on a change in pull request #1657: HIVE-24363: Current order of transactional event listeners is prone t…
Posted by GitBox <gi...@apache.org>.
pkumarsinha commented on a change in pull request #1657:
URL: https://github.com/apache/hive/pull/1657#discussion_r520299532
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -573,7 +573,7 @@ public void init() throws MetaException {
listeners.add(new SessionPropertiesListener(conf));
transactionalListeners = MetaStoreServerUtils.getMetaStoreListeners(TransactionalMetaStoreEventListener.class,
conf, MetastoreConf.getVar(conf, ConfVars.TRANSACTIONAL_EVENT_LISTENERS));
- transactionalListeners.add(new AcidEventListener(conf));
+ transactionalListeners.add(0, new AcidEventListener(conf));
Review comment:
It is small list and the moving will not matter. The current code MetaStoreServerUtils.getMetaStoreListeners() returns empty or a list of listener. The code looks clean this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pkumarsinha commented on a change in pull request #1657: HIVE-24363: Current order of transactional event listeners is prone t…
Posted by GitBox <gi...@apache.org>.
pkumarsinha commented on a change in pull request #1657:
URL: https://github.com/apache/hive/pull/1657#discussion_r521539610
##########
File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java
##########
@@ -1216,8 +1216,10 @@ public static ConfVars getMetaConf(String name) {
"Can notification events from notification log table be used for updating the metastore cache."),
TRANSACTIONAL_EVENT_LISTENERS("metastore.transactional.event.listeners",
"hive.metastore.transactional.event.listeners", "",
- "A comma separated list of Java classes that implement the org.apache.riven.MetaStoreEventListener" +
- " interface. Both the metastore event and corresponding listener method will be invoked in the same JDO transaction."),
+ "A comma separated list of Java classes that implement the org.apache.riven.MetaStoreEventListener interface." +
+ " Both the metastore event and corresponding listener method will be invoked in the same JDO transaction." +
+ " If DbNotificationListener is configured along with other transactional event listenr, make sure it is" +
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #1657: HIVE-24363: Current order of transactional event listeners is prone t…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1657:
URL: https://github.com/apache/hive/pull/1657
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #1657: HIVE-24363: Current order of transactional event listeners is prone t…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1657:
URL: https://github.com/apache/hive/pull/1657#issuecomment-758329009
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] pgaref commented on a change in pull request #1657: HIVE-24363: Current order of transactional event listeners is prone t…
Posted by GitBox <gi...@apache.org>.
pgaref commented on a change in pull request #1657:
URL: https://github.com/apache/hive/pull/1657#discussion_r521496868
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -571,9 +571,12 @@ public void init() throws MetaException {
listeners = MetaStoreServerUtils.getMetaStoreListeners(MetaStoreEventListener.class, conf,
MetastoreConf.getVar(conf, ConfVars.EVENT_LISTENERS));
listeners.add(new SessionPropertiesListener(conf));
- transactionalListeners = MetaStoreServerUtils.getMetaStoreListeners(TransactionalMetaStoreEventListener.class,
- conf, MetastoreConf.getVar(conf, ConfVars.TRANSACTIONAL_EVENT_LISTENERS));
- transactionalListeners.add(new AcidEventListener(conf));
+ transactionalListeners = new ArrayList() {{
Review comment:
Got it, makes sense!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha commented on a change in pull request #1657: HIVE-24363: Current order of transactional event listeners is prone t…
Posted by GitBox <gi...@apache.org>.
aasha commented on a change in pull request #1657:
URL: https://github.com/apache/hive/pull/1657#discussion_r520298358
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
##########
@@ -573,7 +573,7 @@ public void init() throws MetaException {
listeners.add(new SessionPropertiesListener(conf));
transactionalListeners = MetaStoreServerUtils.getMetaStoreListeners(TransactionalMetaStoreEventListener.class,
conf, MetastoreConf.getVar(conf, ConfVars.TRANSACTIONAL_EVENT_LISTENERS));
- transactionalListeners.add(new AcidEventListener(conf));
+ transactionalListeners.add(0, new AcidEventListener(conf));
Review comment:
Since you already know this has to be at the 0th index, you can add this add the beginning instead of shifting all other listeners and adding this to 0th index later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org