You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/05/25 11:38:57 UTC
[GitHub] [lucene] romseygeek opened a new pull request #150: LUCENE-9204: Remove Spans references from DisiWrapper
romseygeek opened a new pull request #150:
URL: https://github.com/apache/lucene/pull/150
We have a number of helper classes in `o.a.l.search` that aid the
implementation of two-phase iteration over disjunctions. These have
some Spans-specific code, which will stop compiling once Spans
are moved into the queries module. This commit removes the
Spans references from the main code and duplicates the helper
code within the Spans package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] romseygeek merged pull request #150: LUCENE-9204: Remove Spans references from DisiWrapper
Posted by GitBox <gi...@apache.org>.
romseygeek merged pull request #150:
URL: https://github.com/apache/lucene/pull/150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] romseygeek commented on pull request #150: LUCENE-9204: Remove Spans references from DisiWrapper
Posted by GitBox <gi...@apache.org>.
romseygeek commented on pull request #150:
URL: https://github.com/apache/lucene/pull/150#issuecomment-847796594
I had hoped to do something similar to what we did for ConjunctionUtils and pull things into shared public factory classes, but that ended up with some very nasty generics code (things like `DisiWrapper<T extends DisiWrapper>`) so I think just cloning the classes here is unfortunately the correct tradeoff to make.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] romseygeek commented on pull request #150: LUCENE-9204: Remove Spans references from DisiWrapper
Posted by GitBox <gi...@apache.org>.
romseygeek commented on pull request #150:
URL: https://github.com/apache/lucene/pull/150#issuecomment-847860278
Thanks for the reviews @mikemccand!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org