[jira] Commented: (HBASE-2863) HBASE-2553 removed an important edge case

["HBase Review Board (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-2863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891052#action_12891052 ] 

HBase Review Board commented on HBASE-2863:
-------------------------------------------

Message from: "Ryan Rawson" <ry...@gmail.com>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/354/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

There are tricky edge cases that were removed by HBASE-2553 (oopsy!)... flaky tests have been illustrating them. This patch fixes those flaky tests to be not flaky (using the EnvironmentEdgeManager thing) and also fixes them, and introduces tests that cover the particular use cases slightly better as well. Oh yes and and fixes the actual bug.

Without these fixes we would end up with KVs with different values with the same Timestamp which causes problems.  This can happen when we get more than 1 increment/millisecond and especially during a snapshot.


This addresses bug HBASE-2863.
    http://issues.apache.org/jira/browse/HBASE-2863


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/KeyValue.java e32d683 
  src/main/java/org/apache/hadoop/hbase/regionserver/MemStore.java 44fa0c3 
  src/main/java/org/apache/hadoop/hbase/regionserver/Store.java c1ff9f2 
  src/main/java/org/apache/hadoop/hbase/util/ManualEnvironmentEdge.java PRE-CREATION 
  src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 4ead02d 
  src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java a32eed6 

Diff: http://review.hbase.org/r/354/diff


Testing
-------


Thanks,

Ryan




> HBASE-2553 removed an important edge case 
> ------------------------------------------
>
>                 Key: HBASE-2863
>                 URL: https://issues.apache.org/jira/browse/HBASE-2863
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>             Fix For: 0.90.0
>
>
> in HBASE-2553 an important edge case whereby a KV with the same TS in snapshot was lost, tests have been failing (but flakly so) indicating it as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.