[GitHub] [helix] dasahcc commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #600: add Helix cloud interface and implementation skeleton methods
URL: https://github.com/apache/helix/pull/600#discussion_r347598841
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
 ##########
 @@ -97,11 +97,12 @@ public ParticipantManager(HelixManager manager, HelixZkClient zkclient, int sess
   }
 
   /**
-   * Handle new session for a participang.
+   * Handle new session for a participant.
    * @throws Exception
    */
   public void handleNewSession() throws Exception {
-    joinCluster();
+
+    autoRegistration();
 
 Review comment:
   Let's not rush for auto registration logic here. We can split it into two PRs. For this PR, let's only have the interface and class implementation. Move the registration logic to separate PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org