You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/11/18 08:23:29 UTC
[PR] HDDS-11702. Merge test_bucket_encryption into robot compatibility test [ozone]
adoroszlai opened a new pull request, #7451:
URL: https://github.com/apache/ozone/pull/7451
## What changes were proposed in this pull request?
`test_bucket_encryption` was added to `xcompat/test.sh` as separate step, but it can be performed as part of the existing write/read test.
Benefits:
- fewer top-level elements in Robot test report
- increase coverage by testing read with all versions
Also, remove duplicated code related to `_init`.
https://issues.apache.org/jira/browse/HDDS-11702
## How was this patch tested?
```
xcompat-cluster-2.0.0-client-1.1.0-write :: Write Compatibility
==============================================================================
Create Encrypted Bucket | PASS |
------------------------------------------------------------------------------
Create Key in Encrypted Bucket | PASS |
...
xcompat-cluster-2.0.0-client-2.0.0-read-1.1.0 :: Read Compatibility
==============================================================================
Key Can Be Read | PASS |
------------------------------------------------------------------------------
Encrypted Key Can Be Read | PASS |
...
```
CI:
https://github.com/adoroszlai/ozone/actions/runs/11882211273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11702. Merge test_bucket_encryption into robot compatibility test [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #7451:
URL: https://github.com/apache/ozone/pull/7451#discussion_r1850872434
##########
hadoop-ozone/dist/src/main/compose/xcompat/test.sh:
##########
@@ -50,6 +50,7 @@ _kinit() {
}
_init() {
+ container=scm
Review Comment:
Others are executed with `new_client` and `old_client` in turn (which define the container), this one needs to be done only once.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11702. Merge test_bucket_encryption into robot compatibility test [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #7451:
URL: https://github.com/apache/ozone/pull/7451#discussion_r1851009495
##########
hadoop-ozone/dist/src/main/smoketest/compatibility/write.robot:
##########
@@ -24,9 +24,16 @@ Suite Setup Create Local Test File
*** Variables ***
${SUFFIX} ${EMPTY}
+${KEY_NAME} key1
Review Comment:
Done.
##########
hadoop-ozone/dist/src/main/compose/xcompat/test.sh:
##########
@@ -74,29 +75,21 @@ _read() {
compatibility/read.robot
}
-test_bucket_encryption() {
- _kinit
- execute_robot_test ${container} -N "xcompat-cluster-${cluster_version}-client-${client_version}" -v SUFFIX:${client_version} security/bucket-encryption.robot
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11702. Merge test_bucket_encryption into robot compatibility test [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #7451:
URL: https://github.com/apache/ozone/pull/7451#discussion_r1850871299
##########
hadoop-ozone/dist/src/main/compose/xcompat/test.sh:
##########
@@ -74,29 +75,21 @@ _read() {
compatibility/read.robot
}
-test_bucket_encryption() {
- _kinit
- execute_robot_test ${container} -N "xcompat-cluster-${cluster_version}-client-${client_version}" -v SUFFIX:${client_version} security/bucket-encryption.robot
Review Comment:
Yes, I was also thinking about that. Since `xcompat` also exercises "current client" with "current cluster", testing the same in `ozonesecure` is redundant. (We can apply this to other functional tests later.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11702. Merge test_bucket_encryption into robot compatibility test [ozone]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on code in PR #7451:
URL: https://github.com/apache/ozone/pull/7451#discussion_r1850859757
##########
hadoop-ozone/dist/src/main/compose/xcompat/test.sh:
##########
@@ -74,29 +75,21 @@ _read() {
compatibility/read.robot
}
-test_bucket_encryption() {
- _kinit
- execute_robot_test ${container} -N "xcompat-cluster-${cluster_version}-client-${client_version}" -v SUFFIX:${client_version} security/bucket-encryption.robot
Review Comment:
Can we delete this robot file now?
##########
hadoop-ozone/dist/src/main/compose/xcompat/test.sh:
##########
@@ -50,6 +50,7 @@ _kinit() {
}
_init() {
+ container=scm
Review Comment:
Why does this method need to explicitly specify this, while other's leave the container variable up to the caller?
##########
hadoop-ozone/dist/src/main/smoketest/compatibility/write.robot:
##########
@@ -24,9 +24,16 @@ Suite Setup Create Local Test File
*** Variables ***
${SUFFIX} ${EMPTY}
+${KEY_NAME} key1
Review Comment:
nit. Can we rename this to ENC_KEY or something similar? Out of context it looks like this is the name that will be used for the actual data key written.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11702. Merge test_bucket_encryption into robot compatibility test [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #7451:
URL: https://github.com/apache/ozone/pull/7451#discussion_r1850873263
##########
hadoop-ozone/dist/src/main/smoketest/compatibility/write.robot:
##########
@@ -24,9 +24,16 @@ Suite Setup Create Local Test File
*** Variables ***
${SUFFIX} ${EMPTY}
+${KEY_NAME} key1
Review Comment:
Yes, but it will affect few other files outside of `xcompat`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11702. Merge test_bucket_encryption into robot compatibility test [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7451:
URL: https://github.com/apache/ozone/pull/7451#issuecomment-2491895022
Thanks @errose28, @hemantk-12 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11702. Merge test_bucket_encryption into robot compatibility test [ozone]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 merged PR #7451:
URL: https://github.com/apache/ozone/pull/7451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org