You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Guangtai Liang (JIRA)" <ji...@codehaus.org> on 2012/02/16 04:54:03 UTC
[jira] (MJAVADOC-342) An incomplete fix for the NPE bugs in
AbstractJavadocMojo.java
Guangtai Liang created MJAVADOC-342:
---------------------------------------
Summary: An incomplete fix for the NPE bugs in AbstractJavadocMojo.java
Key: MJAVADOC-342
URL: https://jira.codehaus.org/browse/MJAVADOC-342
Project: Maven 2.x Javadoc Plugin
Issue Type: Bug
Reporter: Guangtai Liang
Priority: Critical
The fix revision 554202 was aimed to remove an NPE bug on the returned value of "getJavadocDirectory()" in the method "getSourcePaths " of the file "/maven/plugins/trunk/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java" , but it is incomplete.
Since the returned value "getJavadocDirectory()" could be null during the runtime execution, its value should also be null-checked before being dereferenced in other methods.
The buggy code locations the same fix needs to be applied at are as bellows:
Line 2401 of the method "copyJavadocResources";
Line 1505 of the method "getSourcePaths".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MJAVADOC-342) An incomplete fix for the NPE bugs in
AbstractJavadocMojo.java
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJAVADOC-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies closed MJAVADOC-342.
-------------------------------------
Resolution: Fixed
Fix Version/s: 2.9
------------------------------------------------------------------------
r1385200 | bimargulies | 2012-09-15 19:22:45 -0400 (Sat, 15 Sep 2012) | 4 lines
MJAVADOC-342: An incomplete fix for the NPE bugs in AbstractJavadocMojo.java
o protect all the calls to getJavadocDirectory
o update to threadsafe version of maven-shade-plugin.
> An incomplete fix for the NPE bugs in AbstractJavadocMojo.java
> --------------------------------------------------------------
>
> Key: MJAVADOC-342
> URL: https://jira.codehaus.org/browse/MJAVADOC-342
> Project: Maven 2.x Javadoc Plugin
> Issue Type: Bug
> Reporter: Guangtai Liang
> Assignee: Benson Margulies
> Fix For: 2.9
>
>
> The fix revision 554202 was aimed to remove an NPE bug on the returned value of "getJavadocDirectory()" in the method "getSourcePaths " of the file "/maven/plugins/trunk/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java" , but it is incomplete.
> Since the returned value "getJavadocDirectory()" could be null during the runtime execution, its value should also be null-checked before being dereferenced in other methods.
> The buggy code locations the same fix needs to be applied at are as bellows:
> Line 2401 of the method "copyJavadocResources";
> Line 1505 of the method "getSourcePaths".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MJAVADOC-342) An incomplete fix for the NPE bugs in
AbstractJavadocMojo.java
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJAVADOC-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=308561#comment-308561 ]
Benson Margulies commented on MJAVADOC-342:
-------------------------------------------
THis is more likely to get fixed with test case(s) attached.
> An incomplete fix for the NPE bugs in AbstractJavadocMojo.java
> --------------------------------------------------------------
>
> Key: MJAVADOC-342
> URL: https://jira.codehaus.org/browse/MJAVADOC-342
> Project: Maven 2.x Javadoc Plugin
> Issue Type: Bug
> Reporter: Guangtai Liang
> Priority: Critical
>
> The fix revision 554202 was aimed to remove an NPE bug on the returned value of "getJavadocDirectory()" in the method "getSourcePaths " of the file "/maven/plugins/trunk/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java" , but it is incomplete.
> Since the returned value "getJavadocDirectory()" could be null during the runtime execution, its value should also be null-checked before being dereferenced in other methods.
> The buggy code locations the same fix needs to be applied at are as bellows:
> Line 2401 of the method "copyJavadocResources";
> Line 1505 of the method "getSourcePaths".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MJAVADOC-342) An incomplete fix for the NPE bugs in
AbstractJavadocMojo.java
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJAVADOC-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies updated MJAVADOC-342:
--------------------------------------
Priority: Major (was: Critical)
> An incomplete fix for the NPE bugs in AbstractJavadocMojo.java
> --------------------------------------------------------------
>
> Key: MJAVADOC-342
> URL: https://jira.codehaus.org/browse/MJAVADOC-342
> Project: Maven 2.x Javadoc Plugin
> Issue Type: Bug
> Reporter: Guangtai Liang
>
> The fix revision 554202 was aimed to remove an NPE bug on the returned value of "getJavadocDirectory()" in the method "getSourcePaths " of the file "/maven/plugins/trunk/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java" , but it is incomplete.
> Since the returned value "getJavadocDirectory()" could be null during the runtime execution, its value should also be null-checked before being dereferenced in other methods.
> The buggy code locations the same fix needs to be applied at are as bellows:
> Line 2401 of the method "copyJavadocResources";
> Line 1505 of the method "getSourcePaths".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MJAVADOC-342) An incomplete fix for the NPE bugs in
AbstractJavadocMojo.java
Posted by "Marcin Domanski (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJAVADOC-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=300776#comment-300776 ]
Marcin Domanski commented on MJAVADOC-342:
------------------------------------------
This is true p.i.t.a. Out of 3 projects on javadoc:fix (v2.8.1)
* 1 failed with NPE on:
** {code}java.lang.NullPointerException
at org.apache.maven.plugin.javadoc.AbstractFixJavadocMojo.writeParamTag(AbstractFixJavadocMojo.java:1994){code}
* the other failed with (seems to be fixed in Qdox already):
** {code}java.lang.ArrayIndexOutOfBoundsException: 500
at com.thoughtworks.qdox.parser.impl.Parser.val_push(Parser.java:142)
at com.thoughtworks.qdox.parser.impl.Parser.yyparse(Parser.java:1303)
at com.thoughtworks.qdox.parser.impl.Parser.parse(Parser.java:999)
at com.thoughtworks.qdox.JavaDocBuilder.addSource(JavaDocBuilder.java:353)
at com.thoughtworks.qdox.JavaDocBuilder.addSource(JavaDocBuilder.java:381)
at com.thoughtworks.qdox.JavaDocBuilder.addSource(JavaDocBuilder.java:377)
at org.apache.maven.plugin.javadoc.AbstractFixJavadocMojo.getQdoxClasses(AbstractFixJavadocMojo.java:855){code}
* last one was successful
> An incomplete fix for the NPE bugs in AbstractJavadocMojo.java
> --------------------------------------------------------------
>
> Key: MJAVADOC-342
> URL: https://jira.codehaus.org/browse/MJAVADOC-342
> Project: Maven 2.x Javadoc Plugin
> Issue Type: Bug
> Reporter: Guangtai Liang
> Priority: Critical
>
> The fix revision 554202 was aimed to remove an NPE bug on the returned value of "getJavadocDirectory()" in the method "getSourcePaths " of the file "/maven/plugins/trunk/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java" , but it is incomplete.
> Since the returned value "getJavadocDirectory()" could be null during the runtime execution, its value should also be null-checked before being dereferenced in other methods.
> The buggy code locations the same fix needs to be applied at are as bellows:
> Line 2401 of the method "copyJavadocResources";
> Line 1505 of the method "getSourcePaths".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MJAVADOC-342) An incomplete fix for the NPE bugs in
AbstractJavadocMojo.java
Posted by "Benson Margulies (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MJAVADOC-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benson Margulies reassigned MJAVADOC-342:
-----------------------------------------
Assignee: Benson Margulies
> An incomplete fix for the NPE bugs in AbstractJavadocMojo.java
> --------------------------------------------------------------
>
> Key: MJAVADOC-342
> URL: https://jira.codehaus.org/browse/MJAVADOC-342
> Project: Maven 2.x Javadoc Plugin
> Issue Type: Bug
> Reporter: Guangtai Liang
> Assignee: Benson Margulies
>
> The fix revision 554202 was aimed to remove an NPE bug on the returned value of "getJavadocDirectory()" in the method "getSourcePaths " of the file "/maven/plugins/trunk/maven-javadoc-plugin/src/main/java/org/apache/maven/plugin/javadoc/AbstractJavadocMojo.java" , but it is incomplete.
> Since the returned value "getJavadocDirectory()" could be null during the runtime execution, its value should also be null-checked before being dereferenced in other methods.
> The buggy code locations the same fix needs to be applied at are as bellows:
> Line 2401 of the method "copyJavadocResources";
> Line 1505 of the method "getSourcePaths".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira