[GitHub] [pulsar] yuruguo commented on a change in pull request #12349: [Admin] Get schema validation enforce add applied.

[GitBox <gi...@apache.org>]

yuruguo commented on a change in pull request #12349:
URL: https://github.com/apache/pulsar/pull/12349#discussion_r728557787



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java
##########
@@ -1626,9 +1626,10 @@ public void setSubscriptionTypesEnabled(
     @ApiResponses(value = { @ApiResponse(code = 403, message = "Don't have admin permission"),
                             @ApiResponse(code = 404, message = "Tenants or Namespace doesn't exist") })
     public boolean getSchemaValidtionEnforced(@PathParam("tenant") String tenant,
-                                           @PathParam("namespace") String namespace) {
+                                              @PathParam("namespace") String namespace,
+                                              @QueryParam("applied") boolean applied) {

Review comment:
       We should give a `false` default value, as below:
   ```
   @QueryParam("applied")  @DefaultValue("false") boolean applied
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org