You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/03/09 18:41:38 UTC
[GitHub] [accumulo] jmark99 opened a new pull request #2557: Remove explicit FutureReturnValueIgnored from ErrorProne
jmark99 opened a new pull request #2557:
URL: https://github.com/apache/accumulo/pull/2557
By default, all ErrorProne Error patterns are checked. There is no
need to explicitly list FutureReturnValueIgnored as an error pattern.
Only error conditions that you do not wish to check for should be
explicitly listed (with the OFF setting).
Note that it is the opposite for Warning patterns. With the current
configuration you must list any warning patterns you wish to check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] jmark99 commented on pull request #2557: Remove explicit FutureReturnValueIgnored from ErrorProne
Posted by GitBox <gi...@apache.org>.
jmark99 commented on pull request #2557:
URL: https://github.com/apache/accumulo/pull/2557#issuecomment-1063285030
I mistakenly thought the FutureReturnValueIgnored pattern was an ErrorProne error by default, but it is actually just a warning. But it is a warning we wish to check for, therefore the line cannot be removed. The PR will be close without implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] jmark99 commented on a change in pull request #2557: Remove explicit FutureReturnValueIgnored from ErrorProne
Posted by GitBox <gi...@apache.org>.
jmark99 commented on a change in pull request #2557:
URL: https://github.com/apache/accumulo/pull/2557#discussion_r823034950
##########
File path: pom.xml
##########
@@ -1684,7 +1684,6 @@
-Xep:CheckReturnValue:OFF \
-Xep:MustBeClosedChecker:OFF \
-Xep:ReturnValueIgnored:OFF \
- -Xep:FutureReturnValueIgnored:ERROR \
Review comment:
No problem! Will definitely keep it as an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a change in pull request #2557: Remove explicit FutureReturnValueIgnored from ErrorProne
Posted by GitBox <gi...@apache.org>.
dlmarion commented on a change in pull request #2557:
URL: https://github.com/apache/accumulo/pull/2557#discussion_r822988980
##########
File path: pom.xml
##########
@@ -1684,7 +1684,6 @@
-Xep:CheckReturnValue:OFF \
-Xep:MustBeClosedChecker:OFF \
-Xep:ReturnValueIgnored:OFF \
- -Xep:FutureReturnValueIgnored:ERROR \
Review comment:
Except that it's default severity is [WARNING](https://errorprone.info/bugpattern/FutureReturnValueIgnored) and all warnings are disabled in the [configuration](https://github.com/apache/accumulo/blob/main/pom.xml#L1682)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] jmark99 closed pull request #2557: Remove explicit FutureReturnValueIgnored from ErrorProne
Posted by GitBox <gi...@apache.org>.
jmark99 closed pull request #2557:
URL: https://github.com/apache/accumulo/pull/2557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] jmark99 commented on a change in pull request #2557: Remove explicit FutureReturnValueIgnored from ErrorProne
Posted by GitBox <gi...@apache.org>.
jmark99 commented on a change in pull request #2557:
URL: https://github.com/apache/accumulo/pull/2557#discussion_r823009374
##########
File path: pom.xml
##########
@@ -1684,7 +1684,6 @@
-Xep:CheckReturnValue:OFF \
-Xep:MustBeClosedChecker:OFF \
-Xep:ReturnValueIgnored:OFF \
- -Xep:FutureReturnValueIgnored:ERROR \
Review comment:
@dlmarion, sorry, my mistake. I thought it was under the Error pattern list vs the Warning pattern. I'll close this as not implemented. In a future PR related to some other EP related changes, I may consider moving the line beneath the 'warning' comment so keep separate Error patterns from Warning patterns. Would you have any objections to that re-arrangement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a change in pull request #2557: Remove explicit FutureReturnValueIgnored from ErrorProne
Posted by GitBox <gi...@apache.org>.
dlmarion commented on a change in pull request #2557:
URL: https://github.com/apache/accumulo/pull/2557#discussion_r823013225
##########
File path: pom.xml
##########
@@ -1684,7 +1684,6 @@
-Xep:CheckReturnValue:OFF \
-Xep:MustBeClosedChecker:OFF \
-Xep:ReturnValueIgnored:OFF \
- -Xep:FutureReturnValueIgnored:ERROR \
Review comment:
no, I have no issue with that. I would like to keep this at ERROR though, unless we remove the disable all warnings parameter, in case the issue is introduced in new code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org