You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/11/17 06:52:18 UTC
[GitHub] [incubator-pegasus] acelyc111 opened a new pull request, #1246: fix: fix log header not corresponding to level
acelyc111 opened a new pull request, #1246:
URL: https://github.com/apache/incubator-pegasus/pull/1246
https://github.com/apache/incubator-pegasus/issues/1199
In commit https://github.com/apache/incubator-pegasus/pull/1200, we exchange DEBUG level and INFO level, but the log header prefixes have been forgot to update. This patch fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan merged pull request #1246: fix: fix log header not corresponding to level
Posted by GitBox <gi...@apache.org>.
empiredan merged PR #1246:
URL: https://github.com/apache/incubator-pegasus/pull/1246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] levy5307 commented on a diff in pull request #1246: fix: fix log header not corresponding to level
Posted by GitBox <gi...@apache.org>.
levy5307 commented on code in PR #1246:
URL: https://github.com/apache/incubator-pegasus/pull/1246#discussion_r1024813689
##########
src/utils/simple_logger.cpp:
##########
@@ -56,7 +56,7 @@ DSN_DEFINE_validator(stderr_start_level, [](const char *level) -> bool {
static void print_header(FILE *fp, dsn_log_level_t log_level)
{
- static char s_level_char[] = "IDWEF";
Review Comment:
It's better to add an explain to show what is 'I'/'D', and so on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org