You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/05/22 03:51:59 UTC
[GitHub] [skywalking-rocketbot-ui] Fine0830 opened a new pull request #297: Feat: New metrics and custom configurations in dashboard
Fine0830 opened a new pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297
Use new metrics system and custom configurations in dashboard
**screenshots**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632687670
I am doing the offline test and DM with @Fine0830. Polish this PR, and make it suitable for more people to test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632734364
SortedMetrics doesn't show the name correctly.
In the `SelectedRecord`, you should display like this. Copy should follow the same logic.
1. name, if ref-id is empty.
1. name - ref-id, if ref-id is not empty.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632732736
Height config is only working like before,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-635118520
> Could you change all the config keys in full names? From my reading, they were using one char only, and your new keys are correct.
>
> 
There are templates of dashboard and topology
https://github.com/Fine0830/skywalking-rocketbot-ui/tree/feat/dashboard/src/template
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632964542
Add a new option `all services`
This is a frontend logic, once selected, use all services from the selector(common or self) to query metrics and list in the graph.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632733545
Miss readSampledRecords type. `top_n_database_statement`'s metrics type is `SAMPLED_RECORD`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632731597
Changing query type from avg value to all values doesn't work. Don't know why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634638312
This PR is much better now, I think we left the following things to improve
1. Apdex and SLA seem still hiding some default calculation. Such as, `apdex=10000` means 1.0 at the front page, but now, even no calculation rule is set, the value is still correct. SLA has a similar case. Please cross-check the codes.
1. The linear graph type is not configurable, but SLA has the bar graph, but others are linear. I think we should open an option about this, for `get all values` and `get all values of labels`.
1. `All entities(max 30)` should be an option(true or false, default no selected) when `Entity type = service or instance` and metrics query is `get all values`. When clicked, all items in the common selector should be queried and visualized in the current graph. (This is important for @hanahmily 's Prometheus integration, and an important feature as we have removed the comparison view. NOTICE, `max 30` is for avoiding overload when there are 100+ entities. The graph will be a disaster.
1. Separate the service/instance/endpoint dashboard config in the topology pop up page, from the real dashboard. FYI @apache/skywalking-committers, I will add a new GraphQL query to make the backend provide the default configurations for both dashboard and topology pop up page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632964926
The unit doesn't set up right.
I think we should remove the hard code somewhere. And ask user to set up in the metrics title like this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632741685
One key point, we shouldn't/can't hard code anything about any metrics because in the case of the metric, we can't expect which metrics they will generate, and what is the meaning. The only one who knows that is the end-user.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634638312
This PR is much better now, I think we left the following things to improve
1. Apdex and SLA seem still hiding some default calculation. Such as, `apdex=10000` means 1.0 at the front page, but now, even no calculation rule is set, the value is still correct. SLA has a similar case. Please cross-check the codes.
1. The linear graph type is not configurable, but SLA has the bar graph, but others are linear. I think we should open an option about this, for `get all values` and `get all values of labels`.
1. Separate the service/instance/endpoint dashboard config in the topology pop up page, from the real dashboard. FYI @apache/skywalking-committers, I will add a new GraphQL query to make the backend provide the default configurations for both dashboard and topology pop up page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632741685
One key point, we should/can't hard code anything about any metrics because in the case of the metric, we can't expect which metrics they will generate, and what is the meaning. The only one who knows that is the end-user.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632731224
The multiple metrics linear visualization doesn't show the correct backend result.
Also, there are not metrics simple calculations, such as `$value / 1000` to format the value in a more reasonable way.
But once you don't have this, how do you make the successful rate look right, which should not be right. Do you hard code anything? Otherwise, we should show 10000, because the backend query returns 10000.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634638312
This PR is much better now, I think we left the following things to improve
1. Apdex and SLA seem still hiding some default calculation. Such as, `apdex=10000` means 1.0 at the front page, but now, even no calculation rule is set, the value is still correct. SLA has a similar case. Please cross-check the codes.
1. The linear graph type is not configurable, but SLA has the bar graph, but others are linear. I think we should open an option about this, for `get all values` and `get all values of labels`.
1. `All services` and `All instances` should be two options in the `Entity type` selector for `get all values` and `get all values of labels` too. When those two clicked, all items in the common selector should be queried and visualized in the current graph. (This is important for @hanahmily 's prometheus integration, and an important feature as we have removed the comparison view.
1. Separate the service/instance/endpoint dashboard config in the topology pop up page, from the real dashboard. FYI @apache/skywalking-committers, I will add a new GraphQL query to make the backend provide the default configurations for both dashboard and topology pop up page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632730455
Service list on the standard APM page is not right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634638312
This PR is much better now, I think we left the following things to improve
1. Apdex and SLA seem still hiding some default calculation. Such as, `apdex=10000` means 1.0 at the front page, but now, even no calculation rule is set, the value is still correct. SLA has a similar case. Please cross-check the codes.
1. The linear graph type is not configurable, but SLA has the bar graph, but others are linear. I think we should open an option about this, for `get all values` and `get all values of labels`.
1. `All services` and `All instances` should be two options in the `Entity type` selector for `get all values` and `get all values of labels` too. When clicked, all items in the common selector should be queried and visualized in the current graph. (This is important for @hanahmily 's prometheus integration, and an important feature as we have removed the comparison view.
1. Separate the service/instance/endpoint dashboard config in the topology pop up page, from the real dashboard. FYI @apache/skywalking-committers, I will add a new GraphQL query to make the backend provide the default configurations for both dashboard and topology pop up page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634049566
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632731224
The multiple metrics linear visualization doesn't show the correct backend result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634638312
This PR is much better now, I think we left the following things to improve
1. The linear graph type is not configurable, but SLA has the bar graph, but others are linear. I think we should open an option about this, for `get all values` and `get all values of labels`.
1. `All entities(max 30)` should be an option(true or false, default no selected) when `Entity type = service or instance` and metrics query is `get all values`. When clicked, all items in the common selector should be queried and visualized in the current graph. (This is important for @hanahmily 's Prometheus integration, and an important feature as we have removed the comparison view. NOTICE, `max 30` is for avoiding overload when there are 100+ entities. The graph will be a disaster.
1. Separate the service/instance/endpoint dashboard config in the topology pop up page, from the real dashboard. FYI @apache/skywalking-committers, I will add a new GraphQL query to make the backend provide the default configurations for both dashboard and topology pop up page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634638312
This PR is much better now, I think we left the following things to improve
1. The linear graph type is not configurable, but SLA has the bar graph, but others are linear. I think we should open an option about this, for `get all values` and `get all values of labels`. I have noticed, you have `ChartBar` and `ChartLine` on the JSON format.
1. `All entities(max 30)` should be an option(true or false, default no selected) when `Entity type = service or instance` and metrics query is `get all values`. When clicked, all items in the common selector should be queried and visualized in the current graph. (This is important for @hanahmily 's Prometheus integration, and an important feature as we have removed the comparison view. NOTICE, `max 30` is for avoiding overload when there are 100+ entities. The graph will be a disaster.
1. Separate the service/instance/endpoint dashboard config in the topology pop up page, from the real dashboard. FYI @apache/skywalking-committers, I will add a new GraphQL query to make the backend provide the default configurations for both dashboard and topology pop up page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] Fine0830 commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-635124393
> @Fine0830 I think all names should be full names, including topology template.
All of key names? If that, Yes, they are full names.
<img width="485" alt="123" src="https://user-images.githubusercontent.com/20871783/83104653-c28cfd80-a0eb-11ea-8619-1e25ccbac55d.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632737036
Every time, when I can't the component config, and close the config page. I have to refresh the browser page, otherwise, most likely, the change wouldn't take effect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on a change in pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#discussion_r429291032
##########
File path: src/views/components/dashboard/dashboard-item.vue
##########
@@ -93,7 +93,7 @@ limitations under the License. -->
};
}
if (!this.itemConfig.metricLabels && this.itemConfig.metricType === MetricsType.LABELED_VALUE) {
- this.EDIT_COMP_CONFIG({ index: this.index, values: { metricLabels: 'p50, p75, p90, p95, p99' } });
+ this.EDIT_COMP_CONFIG({ index: this.index, values: { metricLabels: PercentileLabels } });
Review comment:
This change is not right. The display should configure through UI by the end-users. Because label query covers more use cases than percentile.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632964143
We need to add a static filter here, once user set this, use `searchServices` rather than `getAllServices` to get service list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-635034168
Could you change all the config keys in full names? From my reading, they were using one char only, and your new keys are correct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-634638312
This PR is much better now, I think we left the following things to improve
1. Apdex and SLA seem still hiding some default calculation. Such as, `apdex=10000` means 1.0 at the front page, but now, even no calculation rule is set, the value is still correct. SLA has a similar case. Please cross-check the codes.
1. The linear graph type is not configurable, but SLA has the bar graph, but others are linear. I think we should open an option about this, for `get all values` and `get all values of labels`.
1. `All entities(max 30)` should be an option when `Entity type = service or instance` and metrics query is `get all values`. When clicked, all items in the common selector should be queried and visualized in the current graph. (This is important for @hanahmily 's Prometheus integration, and an important feature as we have removed the comparison view. NOTICE, `max 30` is for avoiding overload when there are 100+ entities. The graph will be a disaster.
1. Separate the service/instance/endpoint dashboard config in the topology pop up page, from the real dashboard. FYI @apache/skywalking-committers, I will add a new GraphQL query to make the backend provide the default configurations for both dashboard and topology pop up page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng commented on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-635119257
@Fine0830 I think all names should be full names, including topology template.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rocketbot-ui] wu-sheng edited a comment on pull request #297: Feat: New metrics and custom configurations in dashboard
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #297:
URL: https://github.com/apache/skywalking-rocketbot-ui/pull/297#issuecomment-632964542
Add a new option `all services`
This is a frontend logic, once selected, use all services from the selector(common or self) to query metrics and list in the graph. This option could work for `read avg value` and `read all values` in REGULAR_VALUE and LABELED_VALUE metrics. `REGULAR_VALUE` + `read all values` option has a higher priority.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org