You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2011/11/21 07:27:16 UTC
DO NOT REPLY [Bug 118623] New: Update Rhino from 1.5R5 to 1.7R3
https://issues.apache.org/ooo/show_bug.cgi?id=118623
Bug #: 118623
Issue Type: DEFECT
Summary: Update Rhino from 1.5R5 to 1.7R3
Classification: Code
Product: scripting
Version: OOo 3.4 Beta
Platform: PC
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P5
Component: code
AssignedTo: kr@openoffice.org
ReportedBy: hanya.runo@gmail.com
CC: ooo-issues@incubator.apache.org
Created attachment 77037
--> https://issues.apache.org/ooo/attachment.cgi?id=77037
Patch for Rhino1.7R3 itself.
I made a patch to update from Rhino 1.5R5 to 1.7R3. This patch is made by
re-constructing rhino1_5R5.patch for Rhino 1.7R3.
rhino1_7R3.patch includes differences patched during to build Rhino, put it
into rhino/.
rhinoupdate1_7R3.patch gives differences about Makefile of the rhino module and
the script provider for JavaScript.
Remove rhino1_5R5.patch, rhino1_5R5-find_swing.patch and
rhino1_5R5-updateToolTip.patch.
Download rhino1_7R3.zip from:
https://developer.mozilla.org/en/Rhino_downloads_archive and put it into
ext_source as 99d94103662a8d0b571e247a77432ac5-rhino1_7R3.zip.
rhino1_7R3.patch has LGPL header based on the original patch, rhino1_5R5.patch
in the part of difference of OfficeScriptInfo.java.
Rhino 1.7R3 has some files in its debugger mentioned at:
https://developer.mozilla.org/en/Rhino/License .
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118623] Update Rhino from 1.5R5 to 1.7R3
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118623
hanya <ha...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|INVALID |
--- Comment #7 from hanya <ha...@gmail.com> 2011-11-25 06:48:59 UTC ---
>Per the discussion @dev I was wrong on this point: we can download and
patch rhino binary. If this was the reason for setting it invalid then it can
be reopened.
Thank you. I reopened.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118623] Update Rhino from 1.5R5 to 1.7R3
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118623
--- Comment #2 from hanya <ha...@gmail.com> 2011-11-24 12:45:44 UTC ---
This patch needs additional task to update the part to download Rhino source
package. And the package have to be uploaded into the repository.
I am sorry I could not do it because I am not a commiter.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118623] Update Rhino from 1.5R5 to 1.7R3
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118623
hanya <ha...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution| |FIXED
--- Comment #10 from hanya <ha...@gmail.com> 2011-12-23 14:55:32 UTC ---
Thanks about commit the patch and about build system.
Update status to Fixed.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118623] Update Rhino from 1.5R5 to 1.7R3
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118623
--- Comment #4 from hanya <ha...@gmail.com> 2011-11-24 17:11:18 UTC ---
@Pedro
> - FreeBSD uses this patch which will likely be relevant
Now AOO needs Java 5 or 6 and it has w3c dom. If it is there, rhino use it and
xmlbeans is not needed.
https://developer.mozilla.org/en/New_in_Rhino_1.7R1#section_3
> - There is a new file under the LGPL in your first patch
I have mentioned about it in the comment. I have not noticed license header of
most files are updated to AL2 until today. The license header is copyrighted to
Oracle and maybe it is included in SGA. But I could not replace it myself.
> - We still cant carry rhino in our distribution, and downloading + patching
is not acceptable either.
Oh, it seems I confused on it.
> or try Chrome V8
I have tried to make V8-UNO bridge but I have met a problem on exceptions
between V8 and UNO. And I also considered about to use V8 as macro engine.
Python has some useful modules and easy to import to use with Python macros.
But V8 does not have import feature except for the proposed by CommonJS
modules. Java's components can not be used on V8 too. If V8 is introduced as a
macro engine, it takes a position below the Basic.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118623] Update Rhino from 1.5R5 to 1.7R3
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118623
Pedro Giffuni <pf...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pfg@apache.org
--- Comment #3 from Pedro Giffuni <pf...@apache.org> 2011-11-24 13:36:45 UTC ---
Hi;
Three points:
- FreeBSD uses this patch which will likely be relevant
http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/lang/rhino/files/patch-xmlimplsrc%2Bbuild.xml?rev=1.1
- There is a new file under the LGPL in your first patch
- We still cant carry rhino in our distribution, and downloading + patching
is not acceptable either. If we cant use it as a prebuilt binary we will have
to upstream the patches (difficult) or try Chrome V8.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118623] Update Rhino from 1.5R5 to 1.7R3
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118623
--- Comment #6 from Pedro Giffuni <pf...@apache.org> 2011-11-24 18:09:42 UTC ---
(In reply to comment #3)
> - We still cant carry rhino in our distribution, and downloading + patching
> is not acceptable either. If we cant use it as a prebuilt binary we will have
> to upstream the patches (difficult) or try Chrome V8.
Per the discussion @dev I was wrong on this point: we can download and
patch rhino binary. If this was the reason for setting it invalid then it can
be reopened.
I think The new file in the patch can be relicensed directly to avoid the
trouble identifying it at a later time or we can wait until the SGA is
completed.
Thanks for looking at V8!
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
[Bug 118623] Update Rhino from 1.5R5 to 1.7R3
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118623
Oliver-Rainer Wittmann (orw at apache dot org) <or...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
--- Comment #11 from Oliver-Rainer Wittmann (orw at apache dot org) <or...@googlemail.com> ---
getting rid of value "enhancement" for field "severity".
For enhancement the field "issue type" shall be used.
--
You are receiving this mail because:
You are on the CC list for the bug.
DO NOT REPLY [Bug 118623] Update Rhino from 1.5R5 to 1.7R3
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118623
--- Comment #8 from Pedro Giffuni <pf...@apache.org> 2011-11-26 01:18:30 UTC ---
(In reply to comment #4)
> > or try Chrome V8
> I have tried to make V8-UNO bridge but I have met a problem on exceptions
> between V8 and UNO. And I also considered about to use V8 as macro engine.
> Python has some useful modules and easy to import to use with Python macros.
> But V8 does not have import feature except for the proposed by CommonJS
> modules. Java's components can not be used on V8 too. If V8 is introduced as a
> macro engine, it takes a position below the Basic.
I found a V8 Java bridge here:
http://rbackhouse.blogspot.com/2011/03/using-google-v8-javascript-engine-in.html
And the license looks good:
https://github.com/rbackhouse/zazl
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118623] Update Rhino from 1.5R5 to 1.7R3
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118623
hanya <ha...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |INVALID
--- Comment #5 from hanya <ha...@gmail.com> 2011-11-24 17:18:44 UTC ---
According to IP clearance this issue has no feature. -> INVALID
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118623] Update Rhino from 1.5R5 to 1.7R3
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118623
Andre <af...@a-w-f.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |af@a-w-f.de
--- Comment #9 from Andre <af...@a-w-f.de> 2011-12-23 09:42:32 UTC ---
Checked in the changes. The last of the four commits (two were planned, the
other two are due to differences between git and svn and my stupidity) is
revision 1222621.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
DO NOT REPLY [Bug 118623] Update Rhino from 1.5R5 to 1.7R3
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=118623
--- Comment #1 from hanya <ha...@gmail.com> 2011-11-21 06:31:29 UTC ---
Created attachment 77038
--> https://issues.apache.org/ooo/attachment.cgi?id=77038
Patch for Makefile and the script framework for JavaScript.
--
Configure bugmail: https://issues.apache.org/ooo/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.