You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2020/08/14 13:55:58 UTC

[GitHub] [plc4x] JohannaMillet opened a new pull request #178: Fix ToAnsi method : bufferoverflow

JohannaMillet opened a new pull request #178:
URL: https://github.com/apache/plc4x/pull/178


   ToAnsi metod in EipProtocolLogic throws Bufferoverflow exception for tags that have more than one '.' in it.
   Fixed by increased allocated data in Buffer.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [plc4x] chrisdutz commented on pull request #178: Fix ToAnsi method : bufferoverflow

Posted by GitBox <gi...@apache.org>.
chrisdutz commented on pull request #178:
URL: https://github.com/apache/plc4x/pull/178#issuecomment-684920366


   Hi Johanna, 
   
   sorry for me picking this up so late ... I just had a look ... your code changes generally look good, and I'm not going to insist on tests as in that case I would have to reject most of my stuff to ;-)
   
   Does the driver work with your changes? Are you able to read with multiple "." in them? I'm asking this stupid questions as I don't know the protocol and want to understand if this just makes the Execption go away.
   
   Chris


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [plc4x] ottobackwards commented on pull request #178: Fix ToAnsi method : bufferoverflow

Posted by GitBox <gi...@apache.org>.
ottobackwards commented on pull request #178:
URL: https://github.com/apache/plc4x/pull/178#issuecomment-674109352


   Thanks for the contribution.
   Is there a way you can write a unit test for this issue?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [plc4x] chrisdutz merged pull request #178: Fix ToAnsi method : bufferoverflow

Posted by GitBox <gi...@apache.org>.
chrisdutz merged pull request #178:
URL: https://github.com/apache/plc4x/pull/178


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org