[GitHub] [spark] wangyum commented on a change in pull request #29475: [SPARK-32659][SQL] Fix the data issue of inserted DPP on non-atomic type

[GitBox <gi...@apache.org>]

wangyum commented on a change in pull request #29475:
URL: https://github.com/apache/spark/pull/29475#discussion_r476570084



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala
##########
@@ -132,13 +132,13 @@ case class InSubqueryExec(
   def updateResult(): Unit = {
     val rows = plan.executeCollect()
     result = child.dataType match {
-      case _: StructType => rows.toArray
-      case _ => rows.map(_.get(0, child.dataType))
+      case _: StructType => rows.toSet

Review comment:
       Yes, fix it by https://github.com/apache/spark/pull/29475/commits/d1db0bc231eb87a09699a8d3f99e3e64ce2885c6




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org