[GitHub] merlimat closed pull request #1140: Remove master/slave terminology from Pulsar (WIP)

[GitBox <gi...@apache.org>]

merlimat closed pull request #1140: Remove master/slave terminology from Pulsar (WIP)
URL: https://github.com/apache/incubator-pulsar/pull/1140
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pulsar-client-cpp/include/pulsar/ConsumerConfiguration.h b/pulsar-client-cpp/include/pulsar/ConsumerConfiguration.h
index 4ffe6df60..6a24caff7 100644
--- a/pulsar-client-cpp/include/pulsar/ConsumerConfiguration.h
+++ b/pulsar-client-cpp/include/pulsar/ConsumerConfiguration.h
@@ -55,11 +55,11 @@ class ConsumerConfiguration {
      * only a single consumer is allowed to attach to the subscription. Other consumers
      * will get an error message. In Shared subscription, multiple consumers will be
      * able to use the same subscription name and the messages will be dispatched in a
-     * round robin fashion. In Failover subscription, a master-slave subscription model
+     * round robin fashion. In Failover subscription, a primary-failover subscription model
      * allows for multiple consumers to attach to a single subscription, though only one
-     * of them will be ?master? at a given time. Only the master consumer will receive
-     * messages. When the master gets disconnected, one among the slaves will be promoted
-     * to master and will start getting messages.
+     * of them will be ?master? at a given time. Only the primary consumer will receive
+     * messages. When the primary consumer gets disconnected, one among the failover
+     * consumers will be promoted to primary and will start getting messages.
      */
     ConsumerConfiguration& setConsumerType(ConsumerType consumerType);
     ConsumerType getConsumerType() const;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services