You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by jw...@apache.org on 2007/08/08 23:28:59 UTC

svn commit: r564025 - /myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/context/RequestContextImpl.java

Author: jwaldman
Date: Wed Aug  8 14:28:56 2007
New Revision: 564025

URL: http://svn.apache.org/viewvc?view=rev&rev=564025
Log:
https://issues.apache.org/jira/browse/TRINIDAD-145 
ClassCastException when binding number-grouping-separator
On Trunk
Use     
char c = CoreRenderer.toChar(property);
to convert an Object to a char.

The implementation for the 1.2 branch is different; it uses ValueExpression.

Modified:
    myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/context/RequestContextImpl.java

Modified: myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/context/RequestContextImpl.java
URL: http://svn.apache.org/viewvc/myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/context/RequestContextImpl.java?view=diff&rev=564025&r1=564024&r2=564025
==============================================================================
--- myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/context/RequestContextImpl.java (original)
+++ myfaces/trinidad/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/context/RequestContextImpl.java Wed Aug  8 14:28:56 2007
@@ -65,8 +65,8 @@
 import org.apache.myfaces.trinidadinternal.metadata.RegionMetadata;
 
 import org.apache.myfaces.trinidad.context.PartialPageContext;
-import org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.XhtmlConstants;
 import org.apache.myfaces.trinidad.context.RenderingContext;
+import org.apache.myfaces.trinidad.render.CoreRenderer;
 import org.apache.myfaces.trinidadinternal.renderkit.core.CoreRenderKit;
 import org.apache.myfaces.trinidadinternal.share.config.UIXCookie;
 
@@ -276,10 +276,12 @@
   @Override
   public char getNumberGroupingSeparator()
   {
-    Character c = (Character) _bean.getProperty(
+
+    Object property = _bean.getProperty(
       RequestContextBean.NUMBER_GROUPING_SEPARATOR_KEY);
-    if (c != null)
-      return c.charValue();
+    char c = CoreRenderer.toChar(property);
+    if (c != CoreRenderer.CHAR_UNDEFINED)
+      return c;
 
     return (char) 0;
   }
@@ -287,11 +289,12 @@
   @Override
   public char getDecimalSeparator()
   {
-    Character c = (Character) _bean.getProperty(
+    Object property = _bean.getProperty(
       RequestContextBean.DECIMAL_SEPARATOR_KEY);
-    if (c != null)
-      return c.charValue();
-
+    char c = CoreRenderer.toChar(property);
+    if (c != CoreRenderer.CHAR_UNDEFINED)
+      return c;
+      
     return (char) 0;
   }