You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "richardantal (via GitHub)" <gi...@apache.org> on 2024/01/11 14:36:35 UTC
[PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
richardantal opened a new pull request, #1793:
URL: https://github.com/apache/phoenix/pull/1793
Remove files left from Hbase 2.3 compat module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-2172152862
Can you rebase @richardantal ? The patch doesn't apply cleanly anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-2175063866
Yes, it works after mvn install.
Yetus should have taken care of that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-1893124919
I cannot remove the "request changes" review without approving, which I am not ready to do until we have 2.6.0 final to test with.
(and the PR also needs to be updated with the final version)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-1892133914
Please update the commit message, @richardantal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-2176968854
Looks like we need to add support to run tests against 2.6 profile https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-mulitbranch/job/master/688/ ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-1887428515
We still have time, I agree that it'd be cleaner if we removed any 2.3 leftovers in a separate ticket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#discussion_r1452363403
##########
pom.xml:
##########
@@ -1724,6 +1752,22 @@
<hbase.version>${hbase-2.4.runtime.version}</hbase.version>
</properties>
</profile>
+ <profile>
Review Comment:
nit:
Please keep the ascending order, and move this under the 2.5 profiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-2151454218
Now that HBase 2.6.0 is released, we can resume here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-1893123238
Thank you.
Let's get get back to this once 2.6.0 is out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-2226188945
Thanks a lot @stoty @richardantal for getting HBase 2.6 support in and stabilizing tests.
It seems like one last thing we might have to do is adjust client version for 2.6 profile? https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-mulitbranch/job/master/703/testReport/junit/org.apache.phoenix.end2end/BackwardCompatibilityIT/MatrixBuild___Matrix___HBASE_PROFILE____2_6____BuildAndTest___initializationError/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#discussion_r1506148196
##########
phoenix-hbase-compat-2.6.0/src/main/java/org/apache/phoenix/compat/hbase/CompatIndexHalfStoreFileReader.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.compat.hbase;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.io.hfile.CacheConfig;
+import org.apache.hadoop.hbase.io.hfile.HFileInfo;
+import org.apache.hadoop.hbase.io.hfile.ReaderContext;
+import org.apache.hadoop.hbase.regionserver.StoreFileInfo;
+import org.apache.hadoop.hbase.regionserver.StoreFileReader;
+
+import java.io.IOException;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+
+public class CompatIndexHalfStoreFileReader extends StoreFileReader {
+
+ public CompatIndexHalfStoreFileReader(final FileSystem fs, final CacheConfig cacheConf, final Configuration conf,
+ final ReaderContext readerContext, final HFileInfo hFileInfo) throws IOException {
+ super(readerContext, hFileInfo, cacheConf, new StoreFileInfo(conf, fs, new Path(fs.getHomeDirectory().toUri()),
Review Comment:
This is broken.
You need to pass the Path here, and use it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-2172177636
Also this still uses 2.6.0-SNAPSHOT.
Updating to 2.6.0-hadoop3 should let the CI run fully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-2172155677
It is based on an old version, from before we removed 2.4.0. support from HEAD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#discussion_r1506152751
##########
phoenix-hbase-compat-2.6.0/src/main/java/org/apache/phoenix/compat/hbase/CompatIndexHalfStoreFileReader.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.compat.hbase;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.io.hfile.CacheConfig;
+import org.apache.hadoop.hbase.io.hfile.HFileInfo;
+import org.apache.hadoop.hbase.io.hfile.ReaderContext;
+import org.apache.hadoop.hbase.regionserver.StoreFileInfo;
+import org.apache.hadoop.hbase.regionserver.StoreFileReader;
+
+import java.io.IOException;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+
+public class CompatIndexHalfStoreFileReader extends StoreFileReader {
+
+ public CompatIndexHalfStoreFileReader(final FileSystem fs, final CacheConfig cacheConf, final Configuration conf,
+ final ReaderContext readerContext, final HFileInfo hFileInfo) throws IOException {
+ super(readerContext, hFileInfo, cacheConf, new StoreFileInfo(conf, fs, new Path(fs.getHomeDirectory().toUri()),
Review Comment:
This will point to the FS root, and fail.
At least fails on 3.0, and it doesn't ,make sense either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-1895310443
BTW could you please add 2.6 to the multibranch jenkinsfile ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-2172716252
However, most of the checkstyle warnings are relevant.
I'm not sure why the javadoc check failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-2174964891
Does this work fine locally?
`mvn clean javadoc:javadoc -Dskip.code-coverage -DskipTests=true`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#discussion_r1533754389
##########
phoenix-hbase-compat-2.6.0/src/main/java/org/apache/phoenix/compat/hbase/CompatIndexHalfStoreFileReader.java:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.phoenix.compat.hbase;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.io.hfile.CacheConfig;
+import org.apache.hadoop.hbase.io.hfile.HFileInfo;
+import org.apache.hadoop.hbase.io.hfile.ReaderContext;
+import org.apache.hadoop.hbase.regionserver.StoreFileInfo;
+import org.apache.hadoop.hbase.regionserver.StoreFileReader;
+
+import java.io.IOException;
+import java.util.Map;
+import java.util.concurrent.atomic.AtomicInteger;
+
+public class CompatIndexHalfStoreFileReader extends StoreFileReader {
+
+ public CompatIndexHalfStoreFileReader(final FileSystem fs, final CacheConfig cacheConf, final Configuration conf,
+ final ReaderContext readerContext, final HFileInfo hFileInfo) throws IOException {
+ super(readerContext, hFileInfo, cacheConf, new StoreFileInfo(conf, fs, new Path(fs.getHomeDirectory().toUri()),
Review Comment:
You can see how I fixed this in #1815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#discussion_r1452363403
##########
pom.xml:
##########
@@ -1724,6 +1752,22 @@
<hbase.version>${hbase-2.4.runtime.version}</hbase.version>
</properties>
</profile>
+ <profile>
Review Comment:
nit:
Please keep the ascending order, and move this after the 2.5 profiles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-2227755949
Thank you, looks like you're right.
Opened https://issues.apache.org/jira/browse/PHOENIX-7359 to track.
Istvan
On Fri, Jul 12, 2024 at 8:57 PM Viraj Jasani ***@***.***>
wrote:
> Thanks a lot @stoty <https://github.com/stoty> @richardantal
> <https://github.com/richardantal> for getting HBase 2.6 support in and
> stabilizing tests.
> It seems like one last thing we might have to do is adjust client version
> for 2.6 profile?
> https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-mulitbranch/job/master/703/testReport/junit/org.apache.phoenix.end2end/BackwardCompatibilityIT/MatrixBuild___Matrix___HBASE_PROFILE____2_6____BuildAndTest___initializationError/
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/phoenix/pull/1793#issuecomment-2226188945>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AACKM5KIPWVSNSLV2ZCIA53ZMARIPAVCNFSM6AAAAABBWTJIDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRWGE4DQOJUGU>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
*István Tóth* | Sr. Staff Software Engineer
*Email*: ***@***.***
cloudera.com <https://www.cloudera.com>
[image: Cloudera] <https://www.cloudera.com/>
[image: Cloudera on Twitter] <https://twitter.com/cloudera> [image:
Cloudera on Facebook] <https://www.facebook.com/cloudera> [image: Cloudera
on LinkedIn] <https://www.linkedin.com/company/cloudera>
------------------------------
------------------------------
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-2172710626
I see that hose issues are fixed.
Sorry, I must have used an older patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "richardantal (via GitHub)" <gi...@apache.org>.
richardantal commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-1887325920
I removed the HBase 2.3 compat module as it should have been removed in [PHOENIX-6877](https://issues.apache.org/jira/browse/PHOENIX-6877)
And added the new 2.6 modules, git recognises these as renamed some files which is not ideal, maybe it should be done separately.
Also this change can only be merged after the 2.6 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-2172147179
Kicked off a new CI build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "richardantal (via GitHub)" <gi...@apache.org>.
richardantal merged PR #1793:
URL: https://github.com/apache/phoenix/pull/1793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-2172233720
Also update the Phoenix version to 5.3.0-SNAPSHOT in the new compatibility module, I've spent an hour trying to compile it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7172: Support HBase 2.6 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #1793:
URL: https://github.com/apache/phoenix/pull/1793#issuecomment-2172243209
CompatOmidTransactionTable also needs to be updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org