You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2021/10/12 00:48:29 UTC
Review Request 73647: RANGER-3474:RangerHivePlugin enhancement to
handle new Hive commands
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73647/
-----------------------------------------------------------
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3474
https://issues.apache.org/jira/browse/RANGER-3474
Repository: ranger
Description
-------
RANGER-3474:RangerHivePlugin enhancement to handle new Hive commands
Diffs
-----
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java dd758e9f0
Diff: https://reviews.apache.org/r/73647/diff/1/
Testing
-------
- Verified in local VM "Alter Table <TableName> set owner user|role <user_or_role>.
Thanks,
Ramesh Mani
Re: Review Request 73647: RANGER-3474:RangerHivePlugin enhancement to
handle new Hive commands
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73647/#review223607
-----------------------------------------------------------
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
Lines 3167 (patched)
<https://reviews.apache.org/r/73647/#comment312713>
Consider getting current database from SessionState:
if (tableName.contains(".")) {
...
} else {
SessionState ss = SessionState.get();
databaseName = ss.getCurrentDatabase();
}
- Madhan Neethiraj
On Oct. 12, 2021, 12:48 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73647/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2021, 12:48 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3474
> https://issues.apache.org/jira/browse/RANGER-3474
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-3474:RangerHivePlugin enhancement to handle new Hive commands
>
>
> Diffs
> -----
>
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java dd758e9f0
>
>
> Diff: https://reviews.apache.org/r/73647/diff/1/
>
>
> Testing
> -------
>
> - Verified in local VM "Alter Table <TableName> set owner user|role <user_or_role>.
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 73647: RANGER-3474:RangerHivePlugin enhancement to
handle new Hive commands
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73647/#review223609
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 12, 2021, 6:58 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73647/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2021, 6:58 p.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3474
> https://issues.apache.org/jira/browse/RANGER-3474
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-3474:RangerHivePlugin enhancement to handle new Hive commands
>
>
> Diffs
> -----
>
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java dd758e9f0
>
>
> Diff: https://reviews.apache.org/r/73647/diff/2/
>
>
> Testing
> -------
>
> - Verified in local VM "Alter Table <TableName> set owner user|role <user_or_role>.
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 73647: RANGER-3474:RangerHivePlugin enhancement to
handle new Hive commands
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73647/
-----------------------------------------------------------
(Updated Oct. 12, 2021, 6:58 p.m.)
Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Fixed review comments - verified in local vm after the change.
Bugs: RANGER-3474
https://issues.apache.org/jira/browse/RANGER-3474
Repository: ranger
Description
-------
RANGER-3474:RangerHivePlugin enhancement to handle new Hive commands
Diffs (updated)
-----
hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java dd758e9f0
Diff: https://reviews.apache.org/r/73647/diff/2/
Changes: https://reviews.apache.org/r/73647/diff/1-2/
Testing
-------
- Verified in local VM "Alter Table <TableName> set owner user|role <user_or_role>.
Thanks,
Ramesh Mani
Re: Review Request 73647: RANGER-3474:RangerHivePlugin enhancement to
handle new Hive commands
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73647/#review223598
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On Oct. 12, 2021, 12:48 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73647/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2021, 12:48 a.m.)
>
>
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3474
> https://issues.apache.org/jira/browse/RANGER-3474
>
>
> Repository: ranger
>
>
> Description
> -------
>
> RANGER-3474:RangerHivePlugin enhancement to handle new Hive commands
>
>
> Diffs
> -----
>
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java dd758e9f0
>
>
> Diff: https://reviews.apache.org/r/73647/diff/1/
>
>
> Testing
> -------
>
> - Verified in local VM "Alter Table <TableName> set owner user|role <user_or_role>.
>
>
> Thanks,
>
> Ramesh Mani
>
>