You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hama.apache.org by "Edward J. Yoon (JIRA)" <ji...@apache.org> on 2008/12/11 09:59:44 UTC
[jira] Created: (HAMA-134) We don't need to fill C with zeros
We don't need to fill C with zeros
----------------------------------
Key: HAMA-134
URL: https://issues.apache.org/jira/browse/HAMA-134
Project: Hama
Issue Type: Sub-task
Reporter: Edward J. Yoon
Also, let's create/use/return the 'new SubMatrix' directly.
----
public SubMatrix mult(SubMatrix b) {
double[][] C = new double[this.getRows()][b.getColumns()];
for (int i = 0; i < this.getRows(); i++) {
Arrays.fill(C[i], 0);
}
for (int i = 0; i < this.getRows(); i++) {
for (int j = 0; j < b.getColumns(); j++) {
for (int k = 0; k < this.getColumns(); k++) {
C[i][j] += this.get(i, k) * b.get(k, j);
}
}
}
return new SubMatrix(C);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-134) We don't need to fill C with zeros
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Samuel Guo updated HAMA-134:
----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
> We don't need to fill C with zeros
> ----------------------------------
>
> Key: HAMA-134
> URL: https://issues.apache.org/jira/browse/HAMA-134
> Project: Hama
> Issue Type: Sub-task
> Affects Versions: 0.1.0
> Reporter: Edward J. Yoon
> Fix For: 0.1.0
>
> Attachments: HAMA-134.patch
>
>
> Also, let's create/use/return the 'new SubMatrix' directly.
> ----
> public SubMatrix mult(SubMatrix b) {
> double[][] C = new double[this.getRows()][b.getColumns()];
> for (int i = 0; i < this.getRows(); i++) {
> Arrays.fill(C[i], 0);
> }
> for (int i = 0; i < this.getRows(); i++) {
> for (int j = 0; j < b.getColumns(); j++) {
> for (int k = 0; k < this.getColumns(); k++) {
> C[i][j] += this.get(i, k) * b.get(k, j);
> }
> }
> }
> return new SubMatrix(C);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-134) We don't need to fill C with zeros
Posted by "Samuel Guo (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655601#action_12655601 ]
Samuel Guo commented on HAMA-134:
---------------------------------
+1
The patch is great.
I just commit it.
> We don't need to fill C with zeros
> ----------------------------------
>
> Key: HAMA-134
> URL: https://issues.apache.org/jira/browse/HAMA-134
> Project: Hama
> Issue Type: Sub-task
> Affects Versions: 0.1.0
> Reporter: Edward J. Yoon
> Fix For: 0.1.0
>
> Attachments: HAMA-134.patch
>
>
> Also, let's create/use/return the 'new SubMatrix' directly.
> ----
> public SubMatrix mult(SubMatrix b) {
> double[][] C = new double[this.getRows()][b.getColumns()];
> for (int i = 0; i < this.getRows(); i++) {
> Arrays.fill(C[i], 0);
> }
> for (int i = 0; i < this.getRows(); i++) {
> for (int j = 0; j < b.getColumns(); j++) {
> for (int k = 0; k < this.getColumns(); k++) {
> C[i][j] += this.get(i, k) * b.get(k, j);
> }
> }
> }
> return new SubMatrix(C);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HAMA-134) We don't need to fill C with zeros
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655600#action_12655600 ]
Hudson commented on HAMA-134:
-----------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12395819/HAMA-134.patch
against trunk revision 725570.
@author +1. The patch does not contain any @author tags.
tests included -1. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/129/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hama-Patch/129/artifact/trunk/build/reports/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hama-Patch/129/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hama-Patch/129/console
This message is automatically generated.
> We don't need to fill C with zeros
> ----------------------------------
>
> Key: HAMA-134
> URL: https://issues.apache.org/jira/browse/HAMA-134
> Project: Hama
> Issue Type: Sub-task
> Affects Versions: 0.1.0
> Reporter: Edward J. Yoon
> Fix For: 0.1.0
>
> Attachments: HAMA-134.patch
>
>
> Also, let's create/use/return the 'new SubMatrix' directly.
> ----
> public SubMatrix mult(SubMatrix b) {
> double[][] C = new double[this.getRows()][b.getColumns()];
> for (int i = 0; i < this.getRows(); i++) {
> Arrays.fill(C[i], 0);
> }
> for (int i = 0; i < this.getRows(); i++) {
> for (int j = 0; j < b.getColumns(); j++) {
> for (int k = 0; k < this.getColumns(); k++) {
> C[i][j] += this.get(i, k) * b.get(k, j);
> }
> }
> }
> return new SubMatrix(C);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-134) We don't need to fill C with zeros
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-134:
--------------------------------
Fix Version/s: 0.1.0
Affects Version/s: 0.1.0
Status: Patch Available (was: Open)
Submit patch.
> We don't need to fill C with zeros
> ----------------------------------
>
> Key: HAMA-134
> URL: https://issues.apache.org/jira/browse/HAMA-134
> Project: Hama
> Issue Type: Sub-task
> Affects Versions: 0.1.0
> Reporter: Edward J. Yoon
> Fix For: 0.1.0
>
> Attachments: HAMA-134.patch
>
>
> Also, let's create/use/return the 'new SubMatrix' directly.
> ----
> public SubMatrix mult(SubMatrix b) {
> double[][] C = new double[this.getRows()][b.getColumns()];
> for (int i = 0; i < this.getRows(); i++) {
> Arrays.fill(C[i], 0);
> }
> for (int i = 0; i < this.getRows(); i++) {
> for (int j = 0; j < b.getColumns(); j++) {
> for (int k = 0; k < this.getColumns(); k++) {
> C[i][j] += this.get(i, k) * b.get(k, j);
> }
> }
> }
> return new SubMatrix(C);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HAMA-134) We don't need to fill C with zeros
Posted by "Edward J. Yoon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HAMA-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edward J. Yoon updated HAMA-134:
--------------------------------
Attachment: HAMA-134.patch
> We don't need to fill C with zeros
> ----------------------------------
>
> Key: HAMA-134
> URL: https://issues.apache.org/jira/browse/HAMA-134
> Project: Hama
> Issue Type: Sub-task
> Reporter: Edward J. Yoon
> Attachments: HAMA-134.patch
>
>
> Also, let's create/use/return the 'new SubMatrix' directly.
> ----
> public SubMatrix mult(SubMatrix b) {
> double[][] C = new double[this.getRows()][b.getColumns()];
> for (int i = 0; i < this.getRows(); i++) {
> Arrays.fill(C[i], 0);
> }
> for (int i = 0; i < this.getRows(); i++) {
> for (int j = 0; j < b.getColumns(); j++) {
> for (int k = 0; k < this.getColumns(); k++) {
> C[i][j] += this.get(i, k) * b.get(k, j);
> }
> }
> }
> return new SubMatrix(C);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.