[jira] [Commented] (ODFTOOLKIT-474) list decorators with different bullet points

["Svante Schubert (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ODFTOOLKIT-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461570#comment-16461570 ] 

Svante Schubert commented on ODFTOOLKIT-474:
--------------------------------------------

Hello Georg,

thanks for the nice patch, altough I was quite busy, so the review took some time.

 

1) One thing that is absolutely not your fault, you copied a method that creates a file in the temp directory, which should be removed IMHO:

doc.save(ResourceUtilities.getTestOutput("BulletListOutput.odt"));

Use

doc.save(ResourceUtilities.newTestOutputFile("BulletListOutput.odt"));

instead and the test output files appear:

simple\target\test-classes

So I validated the new documents within the online validator: [https://odfvalidator.org/] <- based on the ODF Toolkit Validator

 

2) By this, I realized I got in

simple\src\main\java\org\odftoolkit\simple\text\list\DiscDecorator.java 

an encoding problem:

private static String DEFAULT_BULLET_CHAR = "◦";

the above should be only one character, perhaps it makes sense to change the type from String to char as well.

Could you check on your side if the character is okay and perhaps attach a ZIP to be safe? 

 

Thanks in advance, Georg.

Svante

 

 

> list decorators with different bullet points
> --------------------------------------------
>
>                 Key: ODFTOOLKIT-474
>                 URL: https://issues.apache.org/jira/browse/ODFTOOLKIT-474
>             Project: ODF Toolkit
>          Issue Type: Improvement
>          Components: simple api
>            Reporter: Georg Füchsle
>            Assignee: Svante Schubert
>            Priority: Major
>         Attachments: ListDecoratorImplementation.patch, ListTest.java.patch
>
>
> Now it is not possible to create lists like:
> a) item1
> b) item2
> or
> I) item1
> II) item2
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)