You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2014/01/13 11:42:23 UTC

[jclouds-labs-openstack] Use the OkHttp driver in Marconi to support PATCH methods (#75)

Use the OkHttp driver to support PATCH methods.
Also upgraded to OkHttp 1.3.0 (the version is now defined in `jclouds-project`.

Run all live tests against Rackspace cloud queues and all succeeded, including the `updateClaim` one:

    Tests run: 32, Failures: 0, Errors: 0, Skipped: 0

/cc @everett-toews @zack-shoylev
You can merge this Pull Request by running:

  git pull https://github.com/nacx/jclouds-labs-openstack patch

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds-labs-openstack/pull/75

-- Commit Summary --

  * Use the OkHttp driver in Marconi to support PATCH methods

-- File Changes --

    M openstack-marconi/pom.xml (6)
    M openstack-marconi/src/main/java/org/jclouds/openstack/marconi/v1/MarconiApiMetadata.java (3)
    M openstack-marconi/src/test/java/org/jclouds/openstack/marconi/v1/features/ClaimApiMockTest.java (2)
    M openstack-swift/pom.xml (2)
    M rackspace-autoscale/pom.xml (1)

-- Patch Links --

https://github.com/jclouds/jclouds-labs-openstack/pull/75.patch
https://github.com/jclouds/jclouds-labs-openstack/pull/75.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/75

Re: [jclouds-labs-openstack] Use the OkHttp driver in Marconi to support PATCH methods (#75)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #149](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/149/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/75#issuecomment-32166286

Re: [jclouds-labs-openstack] Use the OkHttp driver in Marconi to support PATCH methods (#75)

Posted by Ignasi Barrera <no...@github.com>.
@everett-toews can we merge this? WDYT?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/75#issuecomment-33943364

Re: [jclouds-labs-openstack] Use the OkHttp driver in Marconi to support PATCH methods (#75)

Posted by Ignasi Barrera <no...@github.com>.
Latest SNAPSHOTS aren't still in place. Will close&reopen in a while to trigger the CI builds again.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/75#issuecomment-32159409

Re: [jclouds-labs-openstack] Use the OkHttp driver in Marconi to support PATCH methods (#75)

Posted by Everett Toews <no...@github.com>.
+100

Huge thanks @nacx 

Will you be backporting this to 1.7.x?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/75#issuecomment-34099945

Re: [jclouds-labs-openstack] Use the OkHttp driver in Marconi to support PATCH methods (#75)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #767](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/767/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/75#issuecomment-32158863

Re: [jclouds-labs-openstack] Use the OkHttp driver in Marconi to support PATCH methods (#75)

Posted by Andrew Phillips <no...@github.com>.
PS: Change itself looks good - +1 from me. Thanks, @nacx!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/75#issuecomment-32170908

Re: [jclouds-labs-openstack] Use the OkHttp driver in Marconi to support PATCH methods (#75)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #148](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/148/) FAILURE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/75#issuecomment-32159177

Re: [jclouds-labs-openstack] Use the OkHttp driver in Marconi to support PATCH methods (#75)

Posted by Ignasi Barrera <no...@github.com>.
Trying once more to trigger the PR builds

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/75#issuecomment-32450950

Re: [jclouds-labs-openstack] Use the OkHttp driver in Marconi to support PATCH methods (#75)

Posted by Andrew Phillips <no...@github.com>.
Actually, BuildHive seems [to be complaining](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/769/console) about something else:
```
[ERROR] 'dependencies.dependency.version' for com.squareup.okhttp:mockwebserver:jar is missing. @ line 109, column 17
```
I'm sure the build itself is fine - just wondering why it's seemingly having trouble picking up the `okhttp.version` from the [project POM](https://github.com/jclouds/jclouds/blob/master/project/pom.xml)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/75#issuecomment-32170875

Re: [jclouds-labs-openstack] Use the OkHttp driver in Marconi to support PATCH methods (#75)

Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs-openstack #769](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs-openstack/769/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/75#issuecomment-32165570

Re: [jclouds-labs-openstack] Use the OkHttp driver in Marconi to support PATCH methods (#75)

Posted by Ignasi Barrera <no...@github.com>.
BuildHive doesn't still see the latest SNAPSHOTS, but the cloudbees build is working now.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/75#issuecomment-32166364

Re: [jclouds-labs-openstack] Use the OkHttp driver in Marconi to support PATCH methods (#75)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-openstack-pull-requests #151](https://jclouds.ci.cloudbees.com/job/jclouds-labs-openstack-pull-requests/151/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/75#issuecomment-32451403

Re: [jclouds-labs-openstack] Use the OkHttp driver in Marconi to support PATCH methods (#75)

Posted by Ignasi Barrera <no...@github.com>.
Verified again the changes by running the live tests against master and 1.7.x. All passed in both branches.

Merged and pushed to both. Thanks for checking @everett-toews !

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/75#issuecomment-34116663