[jira] [Commented] (THRIFT-4558) reserved Csharp keyword are not escaped when field is required

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16440860#comment-16440860 ] 

ASF GitHub Bot commented on THRIFT-4558:
----------------------------------------

pitming opened a new pull request #1546: THRIFT-4558: normalize name in C# constructor
URL: https://github.com/apache/thrift/pull/1546
 
 
   Some helpful tips for a successful Apache Thrift PR:
   
   * Did you test your changes locally or using CI in your fork?
   * Is the Apache Jira THRIFT ticket identifier in the PR title?
   * Is the Apache Jira THRIFT ticket identifier in the commit message?
   * Did you squash your changes to a single commit?
   * Are these changes backwards compatible? (please say so in PR description)
   * Do you need to update the language-specific README?
   
   Example ideal pull request title:
   
           THRIFT-9999: an example pull request title
   
   Example ideal commit message:
   
           THRIFT-9999: [summary of fix, one line if possible]
           Client: [language(s) affected, comma separated, use lib/ directory names please]
   
   For more information about committing, see CONTRIBUTING.md
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> reserved Csharp keyword are not escaped when field is required
> --------------------------------------------------------------
>
>                 Key: THRIFT-4558
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4558
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Compiler
>    Affects Versions: 0.9.3
>            Reporter: Pierre Mignolet
>            Priority: Blocker
>             Fix For: 0.9.3
>
>
> {code:java}
> struct MeMessage {
>  1: optional string fixed
>  7: required string unchecked
> }{code}
> Here reserved fixed C# keyword is escaped via @ but unchecked is not escaped in C# code so code is just not compilable
> ----
> I had a look in t_csharp_generator.cc and keyword are present and method normalize_name should make the escape



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)