You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2014/03/14 20:47:02 UTC

[GitHub] couchdb pull request: Fauxton: highlight databases with more delet...

GitHub user robertkowalski opened a pull request:

    https://github.com/apache/couchdb/pull/181

    Fauxton: highlight databases with more deleted docs than existing

    Fixes COUCHDB-2110

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb 2110-graveyards-in-database-list

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #181
    
----
commit b8accb4eb7c46e3888416afc4aff407487f2f21c
Author: Robert Kowalski <ro...@kowalski.gd>
Date:   2014-03-14T19:45:31Z

    Fauxton: highlight databases with more deleted docs than existing
    
    Fixes COUCHDB-2110

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: highlight databases with more delet...

Posted by robertkowalski <gi...@git.apache.org>.
GitHub user robertkowalski reopened a pull request:

    https://github.com/apache/couchdb/pull/181

    Fauxton: highlight databases with more deleted docs than existing

    Fixes COUCHDB-2110

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/robertkowalski/couchdb 2110-graveyards-in-database-list

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb/pull/181.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #181
    
----
commit b8accb4eb7c46e3888416afc4aff407487f2f21c
Author: Robert Kowalski <ro...@kowalski.gd>
Date:   2014-03-14T19:45:31Z

    Fauxton: highlight databases with more deleted docs than existing
    
    Fixes COUCHDB-2110

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: highlight databases with more delet...

Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb/pull/181#issuecomment-37704427
  
    `src/Makefile.am` is wanted for ` src/fauxton/app/addons/databases/tests/resourcesSpec.js` /:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: highlight databases with more delet...

Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:

    https://github.com/apache/couchdb/pull/181#issuecomment-37690064
  
    merged, thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: highlight databases with more delet...

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb/pull/181#issuecomment-37690143
  
    :D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: highlight databases with more delet...

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb/pull/181#issuecomment-37727091
  
    I'm so sorry!
    
    Ok, that are two times more than needed, I wrote a precommit-hook. Feel free to use it, just add it as executable (`chmod +x $FILENAME`) as `couchdb/.git/hooks/pre-commit`:
    
    ```bash
    #!/bin/sh
    
    files=$(git diff-index --name-status --cached HEAD | grep -v ^D | cut -c3-)
    
    # initial commit - files is null
    if [ -z "$files" ]
    then
      files=$(git diff --cached --root --name-status | grep -v ^D | cut -c3-)
    fi
    
    if [ -n "$files" ]
    then
      for f in $files
      do
        # or still unstaged No newline at end of file
        unstaged=$(git diff $f | grep ${f:4} src/Makefile.am)
        if [ -n "$unstaged" ]
        then
          echo "Errors in file Makefile.am:"
          echo "Unstaged file has info for Makefile.am"
          exit 1
        fi
        unstaged=""
        # return error if not in Makefile.am
        if [ "$(grep ${f:4} src/Makefile.am)" == '' ]
        then
          echo "Error: file not added to Makefile.am"
          exit 1
        fi
      done
      exit 0
    fi
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: highlight databases with more delet...

Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:

    https://github.com/apache/couchdb/pull/181#issuecomment-37729158
  
    @robertkowalski no worries, that's a common mistake (: Thanks for sharing the precommit-hook! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: highlight databases with more delet...

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:

    https://github.com/apache/couchdb/pull/181


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb pull request: Fauxton: highlight databases with more delet...

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski closed the pull request at:

    https://github.com/apache/couchdb/pull/181


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---