You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "martinzink (via GitHub)" <gi...@apache.org> on 2025/10/16 07:38:43 UTC
[PR] MINIFICPP-2652 Remove deprecated bootstrap and win_build_vs.bat [nifi-minifi-cpp]
martinzink opened a new pull request, #2049:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2049
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2652 Remove deprecated bootstrap.sh [nifi-minifi-cpp]
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on PR #2049:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2049#issuecomment-3410917474
These files are still referenced in `conanfile.py` on line 12 in the `shared_sources` variable, we can remove those references there too.
I also found some references of `bootstrap.sh` in the ThirdParties.md documentation that can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2652 Remove deprecated bootstrap.sh [nifi-minifi-cpp]
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink commented on PR #2049:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2049#issuecomment-3414849584
> These files are still referenced in `conanfile.py` on line 12 in the `shared_sources` variable, we can remove those references there too. I also found some references of `bootstrap.sh` in the ThirdParties.md documentation that can be removed.
Good catch, removed them in [review changes](https://github.com/apache/nifi-minifi-cpp/pull/2049/commits/bb197e815dc444c50e12955a0f844275556a7bc0)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2652 Remove deprecated bootstrap.sh [nifi-minifi-cpp]
Posted by "martinzink (via GitHub)" <gi...@apache.org>.
martinzink commented on PR #2049:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2049#issuecomment-3409653863
I've talked with @adamdebreceni and he informed win_vs_build.bat is still useful to create the visual studio project files, so I've readded and changed to scope of this PR to remove only the bootstrap.sh (and its helper scripts)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2652 Remove deprecated bootstrap.sh [nifi-minifi-cpp]
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm closed pull request #2049: MINIFICPP-2652 Remove deprecated bootstrap.sh
URL: https://github.com/apache/nifi-minifi-cpp/pull/2049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org