You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/02/27 19:30:33 UTC
Review Request 31550: Add test coverage for MesosSchedulerImpl.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31550/
-----------------------------------------------------------
Review request for Aurora and Maxim Khutornenko.
Repository: aurora
Description
-------
This brings MesosSchedulerImpl to 100% line and branch coverage.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java aa8aaad975bac513ce7734b4807a2f736b493e69
src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java d621586abc8b0e20ffa6bd2c39aa92bd5512c3dd
Diff: https://reviews.apache.org/r/31550/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 31550: Add test coverage for MesosSchedulerImpl.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31550/#review74564
-----------------------------------------------------------
@ReviewBot retry
Flaky test is tracked at AURORA-1054
- Bill Farner
On Feb. 27, 2015, 6:30 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31550/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 6:30 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This brings MesosSchedulerImpl to 100% line and branch coverage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java aa8aaad975bac513ce7734b4807a2f736b493e69
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java d621586abc8b0e20ffa6bd2c39aa92bd5512c3dd
>
> Diff: https://reviews.apache.org/r/31550/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31550: Add test coverage for MesosSchedulerImpl.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31550/#review74566
-----------------------------------------------------------
Ship it!
Ship It!
- Maxim Khutornenko
On Feb. 27, 2015, 6:30 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31550/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 6:30 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This brings MesosSchedulerImpl to 100% line and branch coverage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java aa8aaad975bac513ce7734b4807a2f736b493e69
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java d621586abc8b0e20ffa6bd2c39aa92bd5512c3dd
>
> Diff: https://reviews.apache.org/r/31550/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31550: Add test coverage for MesosSchedulerImpl.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31550/#review74572
-----------------------------------------------------------
Ship it!
Master (d1a1296) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 27, 2015, 6:30 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31550/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 6:30 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This brings MesosSchedulerImpl to 100% line and branch coverage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java aa8aaad975bac513ce7734b4807a2f736b493e69
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java d621586abc8b0e20ffa6bd2c39aa92bd5512c3dd
>
> Diff: https://reviews.apache.org/r/31550/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 31550: Add test coverage for MesosSchedulerImpl.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31550/#review74536
-----------------------------------------------------------
Master (d1a1296) is red with this patch.
./build-support/jenkins/build.sh
src.test.python.apache.aurora.client.cli.cron ..... SUCCESS
src.test.python.apache.aurora.client.cli.inspect ..... SUCCESS
src.test.python.apache.aurora.client.cli.job ..... SUCCESS
src.test.python.apache.aurora.client.cli.plugins ..... SUCCESS
src.test.python.apache.aurora.client.cli.quota ..... SUCCESS
src.test.python.apache.aurora.client.cli.sla ..... SUCCESS
src.test.python.apache.aurora.client.cli.supdate ..... SUCCESS
src.test.python.apache.aurora.client.cli.task ..... SUCCESS
src.test.python.apache.aurora.client.cli.update ..... SUCCESS
src.test.python.apache.aurora.client.cli.version ..... SUCCESS
src.test.python.apache.aurora.client.config ..... SUCCESS
src.test.python.apache.aurora.client.factory ..... SUCCESS
src.test.python.apache.aurora.client.hooks.hooked_api ..... SUCCESS
src.test.python.apache.aurora.client.hooks.non_hooked_api ..... SUCCESS
src.test.python.apache.aurora.common.test_aurora_job_key ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster ..... SUCCESS
src.test.python.apache.aurora.common.test_cluster_option ..... SUCCESS
src.test.python.apache.aurora.common.test_clusters ..... SUCCESS
src.test.python.apache.aurora.common.test_http_signaler ..... SUCCESS
src.test.python.apache.aurora.common.test_pex_version ..... SUCCESS
src.test.python.apache.aurora.common.test_shellify ..... SUCCESS
src.test.python.apache.aurora.common.test_transport ..... SUCCESS
src.test.python.apache.aurora.config.test_base ..... SUCCESS
src.test.python.apache.aurora.config.test_constraint_parsing ..... SUCCESS
src.test.python.apache.aurora.config.test_loader ..... SUCCESS
src.test.python.apache.aurora.config.test_thrift ..... SUCCESS
src.test.python.apache.aurora.executor.common.path_detector ..... SUCCESS
src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS
src.test.python.apache.aurora.executor.executor_base ..... SUCCESS
src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS
src.test.python.apache.aurora.executor.status_manager ..... SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner ..... FAILURE
src.test.python.apache.thermos.common.test_pathspec ..... SUCCESS
src.test.python.apache.thermos.core.test_runner_integration ..... SUCCESS
src.test.python.apache.thermos.monitoring.test_disk ..... SUCCESS
FAILURE
[31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 27, 2015, 6:30 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31550/
> -----------------------------------------------------------
>
> (Updated Feb. 27, 2015, 6:30 p.m.)
>
>
> Review request for Aurora and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This brings MesosSchedulerImpl to 100% line and branch coverage.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java aa8aaad975bac513ce7734b4807a2f736b493e69
> src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java d621586abc8b0e20ffa6bd2c39aa92bd5512c3dd
>
> Diff: https://reviews.apache.org/r/31550/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>