You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/01/31 13:39:10 UTC
Review Request 56123: Log Search portal date range picker - fix minor
issues
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56123/
-----------------------------------------------------------
Review request for Ambari, Oliver Szabo and Robert Nettleton.
Bugs: AMBARI-19796
https://issues.apache.org/jira/browse/AMBARI-19796
Repository: ambari
Description
-------
- all the dates are selected and "Invalid Date" caption appears if the first day of the month is Sunday
- the date of the loading of the page appears as both start and end time if the mouse is moved over any range button
- the initial value still starts at 1 second after midnight
also removed some unused codes
Diffs
-----
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/js/daterangepicker.js dc571e8
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/ViewUtils.js 6d587cd
ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/DatePickerLayout.js 3beb776
Diff: https://reviews.apache.org/r/56123/diff/
Testing
-------
Tested on local cluster
Thanks,
Miklos Gergely
Re: Review Request 56123: Log Search portal date range picker - fix
minor issues
Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56123/#review163658
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Nettleton
On Jan. 31, 2017, 1:39 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56123/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 1:39 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-19796
> https://issues.apache.org/jira/browse/AMBARI-19796
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - all the dates are selected and "Invalid Date" caption appears if the first day of the month is Sunday
> - the date of the loading of the page appears as both start and end time if the mouse is moved over any range button
> - the initial value still starts at 1 second after midnight
>
> also removed some unused codes
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/js/daterangepicker.js dc571e8
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/ViewUtils.js 6d587cd
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/DatePickerLayout.js 3beb776
>
> Diff: https://reviews.apache.org/r/56123/diff/
>
>
> Testing
> -------
>
> Tested on local cluster
>
>
> Thanks,
>
> Miklos Gergely
>
>
Re: Review Request 56123: Log Search portal date range picker - fix
minor issues
Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56123/#review163655
-----------------------------------------------------------
Ship it!
Ship It!
- Oliver Szabo
On Jan. 31, 2017, 1:39 p.m., Miklos Gergely wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56123/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2017, 1:39 p.m.)
>
>
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
>
>
> Bugs: AMBARI-19796
> https://issues.apache.org/jira/browse/AMBARI-19796
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - all the dates are selected and "Invalid Date" caption appears if the first day of the month is Sunday
> - the date of the loading of the page appears as both start and end time if the mouse is moved over any range button
> - the initial value still starts at 1 second after midnight
>
> also removed some unused codes
>
>
> Diffs
> -----
>
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/libs/other/daterangepicker/js/daterangepicker.js dc571e8
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/utils/ViewUtils.js 6d587cd
> ambari-logsearch/ambari-logsearch-portal/src/main/webapp/scripts/views/common/DatePickerLayout.js 3beb776
>
> Diff: https://reviews.apache.org/r/56123/diff/
>
>
> Testing
> -------
>
> Tested on local cluster
>
>
> Thanks,
>
> Miklos Gergely
>
>