You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jiangjie Qin <be...@gmail.com> on 2015/03/25 00:42:41 UTC
Review Request 32465: Patch for KAFKA-2047
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32465/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-2047
https://issues.apache.org/jira/browse/KAFKA-2047
Repository: kafka
Description
-------
Fix for KAFKA-2047 Accelarate consumer bootstrap consumer rebalance in mirror maker.
Diffs
-----
core/src/main/scala/kafka/tools/MirrorMaker.scala 4f3c4c872e144195bb4b742b802fa3b931edb534
Diff: https://reviews.apache.org/r/32465/diff/
Testing
-------
Thanks,
Jiangjie Qin
Re: Review Request 32465: Patch for KAFKA-2047
Posted by Jiangjie Qin <be...@gmail.com>.
> On March 25, 2015, 8:37 p.m., Guozhang Wang wrote:
> > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 325
> > <https://reviews.apache.org/r/32465/diff/1/?file=904867#file904867line325>
> >
> > Wondering if we call System.exit(-1) directly from one of the MM thread, if we have some shutdown hook in the container will that cause deadlock?
Good point. Actually we can just put everything into the big try/catch/finally block.
- Jiangjie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32465/#review77789
-----------------------------------------------------------
On March 25, 2015, 8:48 p.m., Jiangjie Qin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32465/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 8:48 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2047
> https://issues.apache.org/jira/browse/KAFKA-2047
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Addressed Guozhang's comment.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/MirrorMaker.scala 4f3c4c872e144195bb4b742b802fa3b931edb534
>
> Diff: https://reviews.apache.org/r/32465/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiangjie Qin
>
>
Re: Review Request 32465: Patch for KAFKA-2047
Posted by Guozhang Wang <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32465/#review77789
-----------------------------------------------------------
core/src/main/scala/kafka/tools/MirrorMaker.scala
<https://reviews.apache.org/r/32465/#comment126055>
Wondering if we call System.exit(-1) directly from one of the MM thread, if we have some shutdown hook in the container will that cause deadlock?
- Guozhang Wang
On March 24, 2015, 11:42 p.m., Jiangjie Qin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32465/
> -----------------------------------------------------------
>
> (Updated March 24, 2015, 11:42 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2047
> https://issues.apache.org/jira/browse/KAFKA-2047
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Fix for KAFKA-2047 Accelarate consumer bootstrap consumer rebalance in mirror maker.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/MirrorMaker.scala 4f3c4c872e144195bb4b742b802fa3b931edb534
>
> Diff: https://reviews.apache.org/r/32465/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiangjie Qin
>
>
Re: Review Request 32465: Patch for KAFKA-2047
Posted by Guozhang Wang <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32465/#review77791
-----------------------------------------------------------
Ship it!
Will make the minor change upon checkin.
core/src/main/scala/kafka/tools/MirrorMaker.scala
<https://reviews.apache.org/r/32465/#comment126063>
Changing the comment to "Mirror maker thread ..."
- Guozhang Wang
On March 25, 2015, 8:48 p.m., Jiangjie Qin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32465/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 8:48 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2047
> https://issues.apache.org/jira/browse/KAFKA-2047
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Addressed Guozhang's comment.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/MirrorMaker.scala 4f3c4c872e144195bb4b742b802fa3b931edb534
>
> Diff: https://reviews.apache.org/r/32465/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiangjie Qin
>
>
Re: Review Request 32465: Patch for KAFKA-2047
Posted by Guozhang Wang <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32465/#review77794
-----------------------------------------------------------
core/src/main/scala/kafka/tools/MirrorMaker.scala
<https://reviews.apache.org/r/32465/#comment126068>
Also here: "just one"
- Guozhang Wang
On March 25, 2015, 8:48 p.m., Jiangjie Qin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32465/
> -----------------------------------------------------------
>
> (Updated March 25, 2015, 8:48 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2047
> https://issues.apache.org/jira/browse/KAFKA-2047
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Addressed Guozhang's comment.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/MirrorMaker.scala 4f3c4c872e144195bb4b742b802fa3b931edb534
>
> Diff: https://reviews.apache.org/r/32465/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jiangjie Qin
>
>
Re: Review Request 32465: Patch for KAFKA-2047
Posted by Jiangjie Qin <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32465/
-----------------------------------------------------------
(Updated March 25, 2015, 8:48 p.m.)
Review request for kafka.
Bugs: KAFKA-2047
https://issues.apache.org/jira/browse/KAFKA-2047
Repository: kafka
Description (updated)
-------
Addressed Guozhang's comment.
Diffs (updated)
-----
core/src/main/scala/kafka/tools/MirrorMaker.scala 4f3c4c872e144195bb4b742b802fa3b931edb534
Diff: https://reviews.apache.org/r/32465/diff/
Testing
-------
Thanks,
Jiangjie Qin