You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "jonmeredith (via GitHub)" <gi...@apache.org> on 2023/02/14 00:12:17 UTC
[GitHub] [cassandra] jonmeredith commented on a diff in pull request #2151: CASSANDRA-18242 trunk
jonmeredith commented on code in PR #2151:
URL: https://github.com/apache/cassandra/pull/2151#discussion_r1105147444
##########
ide/idea/workspace.xml:
##########
@@ -173,7 +183,28 @@
<option name="MAIN_CLASS_NAME" value="" />
<option name="METHOD_NAME" value="" />
<option name="TEST_OBJECT" value="class" />
- <option name="VM_PARAMETERS" value="-Dcassandra.config=file://$PROJECT_DIR$/test/conf/cassandra.yaml -Dlogback.configurationFile=file://$PROJECT_DIR$/test/conf/logback-test.xml -Dcassandra.logdir=$PROJECT_DIR$/build/test/logs -Djava.library.path=$PROJECT_DIR$/lib/sigar-bin -Dlegacy-sstable-root=$PROJECT_DIR$/test/data/legacy-sstables -Dinvalid-legacy-sstable-root=$PROJECT_DIR$/test/data/invalid-legacy-sstables -Dcassandra.ring_delay_ms=1000 -Dcassandra.skip_sync=true -ea -XX:MaxMetaspaceSize=1G -XX:SoftRefLRUPolicyMSPerMB=0 -XX:HeapDumpPath=build/test -XX:ActiveProcessorCount=2 -Dcassandra.strict.runtime.checks=true -Dlegacy-sstable-root=$PROJECT_DIR$/test/data/legacy-sstables -Dinvalid-legacy-sstable-root=$PROJECT_DIR$/test/data/invalid-legacy-sstables -Dmigration-sstable-root=$PROJECT_DIR$/test/data/migration-sstables -Dcassandra.ring_delay_ms=1000 -Dcassandra.tolerate_sstable_size=true -Dcassandra.skip_sync=true -Dcassandra.reads.thresholds.coordinator.defensive_checks_enab
led=true -Dcassandra.use_nix_recursive_delete=true -Dcassandra.test.messagingService.nonGracefulShutdown=true -Dcassandra.test.flush_local_schema_changes=false " />
+ <option name="VM_PARAMETERS" value="
+ -Dcassandra.config=file://$PROJECT_DIR$/test/conf/cassandra.yaml
+ -Dcassandra.logdir=$PROJECT_DIR$/build/test/logs
+ -Dcassandra.reads.thresholds.coordinator.defensive_checks_enabled=true
+ -Dcassandra.ring_delay_ms=1000
+ -Dcassandra.skip_sync=true
+ -Dcassandra.strict.runtime.checks=true
+ -Dcassandra.test.flush_local_schema_changes=false
+ -Dcassandra.test.messagingService.nonGracefulShutdown=true
+ -Dcassandra.tolerate_sstable_size=true
+ -Dcassandra.use_nix_recursive_delete=true
+ -Dinvalid-legacy-sstable-root=$PROJECT_DIR$/test/data/invalid-legacy-sstables
+ -Djava.library.path=$PROJECT_DIR$/lib/sigar-bin
+ -Dlegacy-sstable-root=$PROJECT_DIR$/test/data/legacy-sstables
+ -Dlogback.configurationFile=file://$PROJECT_DIR$/test/conf/logback-test.xml
+ -Dmigration-sstable-root=$PROJECT_DIR$/test/data/migration-sstables
+ -XX:ActiveProcessorCount=2
+ -XX:HeapDumpPath=build/test
+ -XX:MaxMetaspaceSize=1G
+ -XX:SoftRefLRUPolicyMSPerMB=0
+ -ea
+ -Didea.click.expand.for.rest.of.options" />
Review Comment:
It was an attempt to remind somebody looking at the IDEA GUI that there were options that weren't visible due to all the whitespace. As it caused confusion in review I'll just remove it.
##########
ide/idea/workspace.xml:
##########
@@ -193,7 +224,18 @@
<configuration default="false" name="Cassandra" type="Application" factoryName="Application">
<extension name="coverage" enabled="false" merge="false" sample_coverage="true" runner="idea" />
<option name="MAIN_CLASS_NAME" value="org.apache.cassandra.service.CassandraDaemon" />
- <option name="VM_PARAMETERS" value="-Dcassandra-foreground=yes -Dcassandra.config=file://$PROJECT_DIR$/conf/cassandra.yaml -Dcassandra.storagedir=$PROJECT_DIR$/data -Dlogback.configurationFile=file://$PROJECT_DIR$/conf/logback.xml -Dcassandra.logdir=$PROJECT_DIR$/data/logs -Djava.library.path=$PROJECT_DIR$/lib/sigar-bin -Dcassandra.jmx.local.port=7199 -ea -Xmx1G -Dcassandra.reads.thresholds.coordinator.defensive_checks_enabled=true -XX:HeapDumpPath=build/test" />
+ <option name="VM_PARAMETERS" value="
+ -Dcassandra-foreground=yes
+ -Dcassandra.config=file://$PROJECT_DIR$/conf/cassandra.yaml
+ -Dcassandra.jmx.local.port=7199
+ -Dcassandra.logdir=$PROJECT_DIR$/data/logs
+ -Dcassandra.reads.thresholds.coordinator.defensive_checks_enabled=true
+ -Dcassandra.storagedir=$PROJECT_DIR$/data
+ -Djava.library.path=$PROJECT_DIR$/lib/sigar-bin
+ -Dlogback.configurationFile=file://$PROJECT_DIR$/conf/logback.xml
+ -Xmx1G
+ -ea
Review Comment:
excellent eyes - mistake, will add back in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org