[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1587: [CELEBORN-676] Celeborn fetch chunk also should support check timeout

["AngersZhuuuu (via GitHub)" <gi...@apache.org>]

AngersZhuuuu commented on code in PR #1587:
URL: https://github.com/apache/incubator-celeborn/pull/1587#discussion_r1228902981


##########
common/src/main/java/org/apache/celeborn/common/network/client/TransportResponseHandler.java:
##########
@@ -63,7 +64,11 @@ public class TransportResponseHandler extends MessageHandler<ResponseMessage> {
 
   private final long pushTimeoutCheckerInterval;
   private static ScheduledExecutorService pushTimeoutChecker = null;
-  private ScheduledFuture scheduleFuture;
+  private ScheduledFuture pushCheckerScheduleFuture;
+
+  private final long fetchTimeoutCheckerInterval;
+  private static ScheduledExecutorService fetchTimeoutChecker = null;

Review Comment:
   > move static variables before members
   
   Add this to control one executor only one fetch executor checker



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org