[GitHub] [iceberg] kbendick commented on a diff in pull request #5009: [CORE] - Fix snapshot summary generating partition summary metrics for unpartitioned tables

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #5009:
URL: https://github.com/apache/iceberg/pull/5009#discussion_r919695184


##########
spark/v2.4/spark/src/test/java/org/apache/iceberg/spark/source/TestIcebergSourceTablesBase.java:
##########
@@ -783,7 +783,7 @@ public void testSnapshotsTable() {
             .set("summary", ImmutableMap.of(
                 "added-records", "1",
                 "added-data-files", "1",
-                "changed-partition-count", "1",
+                "changed-partition-count", "0",

Review Comment:
   I agree that the root should be considered a partition of its own. Suppressing the root partition summary is sufficient.
   
   Will update 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org