You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/31 14:45:58 UTC
[jira] [Commented] (BEAM-700) Update FileBasedSource to use
sampling when estimating size of file patterns
[ https://issues.apache.org/jira/browse/BEAM-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15622348#comment-15622348 ]
ASF GitHub Bot commented on BEAM-700:
-------------------------------------
GitHub user chamikaramj opened a pull request:
https://github.com/apache/incubator-beam/pull/1235
[BEAM-700] Improvements related to size estimation.
Updates FileBasedSource so that size estimation of glob patterns that expand into a large number of files is done using sampling.
Updates Dataflow runner to set estimated sizes of sources when submitting jobs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chamikaramj/incubator-beam estimate_size_of_sources
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/1235.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1235
----
commit 42b1d9f541a54ea49ec717934632e8e82c21e911
Author: chamikara@google.com <ch...@google.com>
Date: 2016-10-31T14:39:13Z
Improvements related to size estimation.
Updates FileBasedSource so that size estimation of glob patterns that expand into a large number of files is done using sampling.
Updates Dataflow runner to set estimated sizes of sources when submitting jobs.
----
> Update FileBasedSource to use sampling when estimating size of file patterns
> ----------------------------------------------------------------------------
>
> Key: BEAM-700
> URL: https://issues.apache.org/jira/browse/BEAM-700
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Reporter: Chamikara Jayalath
> Assignee: Chamikara Jayalath
> Fix For: Not applicable
>
>
> Currently when estimating size of file patterns we estimate size of each file and add the sizes up [1]. This can be very inefficient for file patterns that expand into a large number of files. We should update FIleBasedSource to use sampling similar to Java SDK [2].
> [1]https://github.com/apache/incubator-beam/blob/python-sdk/sdks/python/apache_beam/io/filebasedsource.py#L120
> [2] https://github.com/apache/incubator-beam/blob/python-sdk/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSource.java#L204
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)