You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by be...@apache.org on 2025/02/24 03:57:28 UTC

(spark) branch master updated: [SPARK-51297][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md

This is an automated email from the ASF dual-hosted git repository.

beliefer pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new f1d78dc2df26 [SPARK-51297][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md
f1d78dc2df26 is described below

commit f1d78dc2df26acd0d71b7040c2767c2d6503dde9
Author: huanxiaodong <hu...@dserspro.com>
AuthorDate: Mon Feb 24 11:57:14 2025 +0800

    [SPARK-51297][DOCS] Fixed the scope of the query option in sql-data-sources-jdbc.md
    
    ### What changes were proposed in this pull request?
    The documentation shows that the scope of jdbc's option is read/write, but after looking at the source code and testing it, it should actually only be read.
    This error has persisted for multiple versions and is still not fixed.
    
    source code:
    https://github.com/apache/spark/blob/a661f9f305d96331338938e14b6ea0075f234aee/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala#L287
    code snippet:
    ![SnBKfLO4Fu](https://github.com/user-attachments/assets/93162fc6-fd3f-4c7a-8e36-413c50e3d8ff)
    test snippet:
    ![WWWQRqH6jS](https://github.com/user-attachments/assets/07e3191e-406e-46aa-85a9-9c7902892db3)
    
    ### Why are the changes needed?
    This avoids user confusion about the use of this option and avoids errors in its use
    
    ### Does this PR introduce _any_ user-facing change?
    No
    
    ### How was this patch tested?
    No testing required, just modifying the document
    
    ### Was this patch authored or co-authored using generative AI tooling?
    No
    
    Closes #50048 from llphxd/fix_jdbc_doc.
    
    Lead-authored-by: huanxiaodong <hu...@dserspro.com>
    Co-authored-by: huanxiaodong <ll...@gmail.com>
    Signed-off-by: beliefer <be...@163.com>
---
 docs/sql-data-sources-jdbc.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/sql-data-sources-jdbc.md b/docs/sql-data-sources-jdbc.md
index 9ea6e8a1e69a..bf53ffa65d61 100644
--- a/docs/sql-data-sources-jdbc.md
+++ b/docs/sql-data-sources-jdbc.md
@@ -96,7 +96,7 @@ logging into the data sources.
             </code></li>
       </ol>
     </td>
-    <td>read/write</td>
+    <td>read</td>
   </tr>
   <tr>
     <td><code>prepareQuery</code></td>


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org